openstack/tripleo-common
Code Issues Proposed changes

Create config-download-latest symlink

Browse Source 
Each time the config-download workflow is run, create a symlink at
/var/lib/mistral/config-download-latest that will point to the latest
execution uuid under /var/lib/mistral. This will make it easier for
users to quickly find the latest config-download working directory.

Change-Id: I9375f343a70653203cb984065e14fe616a35c5cc
This commit is contained in:
James Slagle 2018-05-30 14:52:37 -04:00
parent eb7d89cab1
commit 1df519b403
2 changed files with 59 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tripleo_common/actions/config.py
View File

@ -83,4 +83,9 @@ class DownloadConfigAction(templates.ProcessTemplatesAction):
swift = self.get_object_client(context)
swiftutils.download_container(swift, self.container_config,
self.work_dir)
symlink_path = os.path.join(
os.path.dirname(self.work_dir), 'config-download-latest')
if os.path.exists(symlink_path):
os.unlink(symlink_path)
os.symlink(self.work_dir, symlink_path)
return self.work_dir

55
tripleo_common/tests/actions/test_config.py
View File

@ -13,6 +13,7 @@
# License for the specific language governing permissions and limitations
# under the License.
import mock
import os
from tripleo_common.actions import config
from tripleo_common.tests import base
@ -107,12 +108,64 @@ class DownloadConfigActionTest(base.TestCase):
self.ctx = mock.MagicMock()
@mock.patch('tripleo_common.actions.config.os.unlink')
@mock.patch('tripleo_common.actions.config.os.path.exists')
@mock.patch('tripleo_common.actions.config.os.symlink')
@mock.patch('tripleo_common.utils.swift.download_container')
@mock.patch('tempfile.mkdtemp')
def test_run(self, mock_mkdtemp,
mock_swiftutils):
mock_swiftutils,
mock_os_symlink,
mock_os_path_exists,
mock_os_unlink):
action = config.DownloadConfigAction(self.config_container)
action.run(self.ctx)
mock_swiftutils.assert_called_once_with(self.swift,
self.config_container,
mock_mkdtemp())
@mock.patch('tripleo_common.actions.config.os.path.exists')
@mock.patch('tripleo_common.actions.config.os.symlink')
@mock.patch('tripleo_common.utils.swift.download_container')
@mock.patch('tempfile.mkdtemp')
def test_run_create_latest_symlink(
self, mock_mkdtemp,
mock_swiftutils,
mock_os_symlink,
mock_os_path_exists):
mock_mkdtemp.return_value = '/var/lib/mistral/uuid'
mock_os_path_exists.return_value = False
action = config.DownloadConfigAction(self.config_container)
action.run(self.ctx)
mock_swiftutils.assert_called_once_with(self.swift,
self.config_container,
mock_mkdtemp())
mock_os_symlink.assert_called_once_with(
action.work_dir,
os.path.join(os.path.dirname(action.work_dir),
'config-download-latest'))
@mock.patch('tripleo_common.actions.config.os.unlink')
@mock.patch('tripleo_common.actions.config.os.path.exists')
@mock.patch('tripleo_common.actions.config.os.symlink')
@mock.patch('tripleo_common.utils.swift.download_container')
@mock.patch('tempfile.mkdtemp')
def test_run_update_latest_symlink(
self, mock_mkdtemp,
mock_swiftutils,
mock_os_symlink,
mock_os_path_exists,
mock_os_unlink):
mock_mkdtemp.return_value = '/var/lib/mistral/uuid'
mock_os_path_exists.return_value = True
action = config.DownloadConfigAction(self.config_container)
action.run(self.ctx)
mock_swiftutils.assert_called_once_with(self.swift,
self.config_container,
mock_mkdtemp())
mock_os_symlink.assert_called_once_with(
action.work_dir,
os.path.join(os.path.dirname(action.work_dir),
'config-download-latest'))
mock_os_unlink.assert_called_once_with(
'/var/lib/mistral/config-download-latest')