Update patch set 1
Patch Set 1: (2 comments) Patch-set: 1 CC: Gerrit User 11604 <11604@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Attention: {"person_ident":"Gerrit User 22954 \u003c22954@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_11604\u003e replied on the change"}
This commit is contained in:
parent
f7e60aef53
commit
2ff01f576b
|
@ -1,5 +1,22 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "5981c108_f880e72d",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 10,
|
||||
"author": {
|
||||
"id": 11604
|
||||
},
|
||||
"writtenOn": "2023-07-04T10:50:22Z",
|
||||
"side": 1,
|
||||
"message": "i think the intent of this patch is correct i cant comment on the implemation of it since i do not understand this part of tripleo at all.",
|
||||
"revId": "2d5ae80c34b2d20382324639983bd6d7e88ecd85",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
|
@ -39,6 +56,30 @@
|
|||
},
|
||||
"revId": "2d5ae80c34b2d20382324639983bd6d7e88ecd85",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "0996e951_8251e318",
|
||||
"filename": "container-images/tripleo_containers.yaml.j2",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 549,
|
||||
"author": {
|
||||
"id": 11604
|
||||
},
|
||||
"writtenOn": "2023-07-04T10:50:22Z",
|
||||
"side": 1,
|
||||
"message": "you are probaly correct that theses should be removed but i dont know currely why this is duplciated \n\nif we were to list the services under only one of the containers the nova-libvirt contaienr makes the most sense.",
|
||||
"parentUuid": "2f211464_32b469e1",
|
||||
"range": {
|
||||
"startLine": 548,
|
||||
"startChar": 0,
|
||||
"endLine": 549,
|
||||
"endChar": 44
|
||||
},
|
||||
"revId": "2d5ae80c34b2d20382324639983bd6d7e88ecd85",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue