Fix Octavia certificate file path and content

Certificate files were being created in a wrong path and with invalid
content. The bug was caused because Ansible variables were not being
quoted, and as so Ansible assumed plain text instead.

Closes-Bug: #1830190

Change-Id: Ie576537d77b57927d430f20b274d1cb5d351241e

playbooks/roles/octavia-controller-config/tasks/certificate.yml

@@ -10,13 +10,13 @@
     become: true
     copy:
       content: "{{ item.content }}"
-      dest: "{{ octavia_confd_prefix }}{{ item.path }}"
+      dest: "{{ octavia_confd_prefix }}/{{ item.path }}"
       selevel: s0
       setype: svirt_sandbox_file_t
     no_log: true
     loop:
-        - { content: private_key_content, path: ca_private_key_path }
-        - { content: ca_cert_content, path: ca_cert_path }
-        - { content: service_pem_content, path: client_cert_path }
+        - { content: "{{ private_key_content }}", path: "{{ ca_private_key_path }}" }
+        - { content: "{{ ca_cert_content }}", path: "{{ ca_cert_path }}" }
+        - { content: "{{ service_pem_content }}" , path: "{{ client_cert_path }}" }
     notify:
       - octavia config updated

releasenotes/notes/octavia-fix-certificates-path-and-content-e8acf1e859e75135.yaml

@@ -0,0 +1,6 @@
+---
+fixes:
+  - |
+    Fixed an issue were amphora load balancers would fail to create. The
+    problem was because Octavia certificate files were being created in a wrong
+    path and with invalid content.