openstack/tripleo-common
Code Issues Proposed changes

Fix ImageBuildManager initialization after BaseImageManager changes

Browse Source 
BaseImageManager's init function used to take two arguments:
'config_files' and 'images' in that order. Commit
08a8118f1b26a170219c63feb8bb5f0b929028c3 added another one in between
the two, 'template_dir'.

ImageBuildManager inherits from BaseImageManager and calls its init
function with 'config_files' and 'images' as positional arguments, which
no longer works because 'images' is now the third argument. Therefore
the value passed as 'images' gets quietly written as 'template_dir'
instead.

Passing 'images' as a keyword argument instead solves the issue.

Change-Id: I591345985ccbb8ebfdf9848104478ec1aadb4a7f
This commit is contained in:
Miguel Garcia 2022-07-26 18:00:08 +02:00
parent 0b83227bdb
commit 6939ec8b46
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tripleo_common/image/build.py
View File

@ -37,7 +37,7 @@ class ImageBuildManager(BaseImageManager):
def __init__(self, config_files, images=None, output_directory='.',
skip=False):
super(ImageBuildManager, self).__init__(config_files, images)
super(ImageBuildManager, self).__init__(config_files, images=images)
self.output_directory = re.sub('[/]$', '', output_directory)
self.skip = skip