openstack/tripleo-common
Code Issues Proposed changes

Rename stack_update to _stack_update

Browse Source 
This clarifies the public API as stack_update was never intended
to be public.

Change-Id: I7f474e5afacb0f2a20095450fabf0cc0801d1b01
This commit is contained in:
Dougal Matthews
2015-10-16 16:16:04 +01:00
parent aa7dc205bd
commit 852ded4e67
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

0
tripleo_common/stack_update.py → tripleo_common/_stack_update.py
View File

4
tripleo_common/tests/test_stack_update.py
View File

@@ -16,7 +16,7 @@
import mock import mock
from tripleo_common import stack_update from tripleo_common import _stack_update
from tripleo_common.tests import base from tripleo_common.tests import base
@@ -71,7 +71,7 @@ class StackUpdateManagerTest(base.TestCase):
] ]
self.heatclient.events.list.side_effect = return_events self.heatclient.events.list.side_effect = return_events
self.stack_update_manager = stack_update.StackUpdateManager( self.stack_update_manager = _stack_update.StackUpdateManager(
self.heatclient, self.novaclient, self.stack, 'pre-update') self.heatclient, self.novaclient, self.stack, 'pre-update')
def test_get_status(self): def test_get_status(self):

4
tripleo_common/update.py
View File

@@ -18,7 +18,7 @@ import os
import time import time
from heatclient.common import template_utils from heatclient.common import template_utils
from tripleo_common import stack_update from tripleo_common import _stack_update
LOG = logging.getLogger(__name__) LOG = logging.getLogger(__name__)
TEMPLATE_NAME = 'overcloud-without-mergepy.yaml' TEMPLATE_NAME = 'overcloud-without-mergepy.yaml'
@@ -33,7 +33,7 @@ def add_breakpoints_cleanup_into_env(env):
}) })
class PackageUpdateManager(stack_update.StackUpdateManager): class PackageUpdateManager(_stack_update.StackUpdateManager):
def __init__(self, heatclient, novaclient, stack_id, def __init__(self, heatclient, novaclient, stack_id,
tht_dir=None, environment_files=None): tht_dir=None, environment_files=None):
stack = heatclient.stacks.get(stack_id) stack = heatclient.stacks.get(stack_id)