openstack
/
tripleo-common
Code Issues Proposed changes

Restore default log path for image prepare 

If logging paths weren't configured in handlers, use default /var/log
for tripleo-container-image-prepare.log along with its *ansible
counterpart used for logging the container image prepare bits.

Closes-Bug: #1866676
Change-Id: I3edbb1b81d5b75519d2bb46f7af04dc833fce9b7
Signed-off-by: Bogdan Dobrelya <bdobreli@redhat.com>
(cherry picked from commit b5668d01d5)
This commit is contained in:
Bogdan Dobrelya 2020-08-10 09:45:06 +02:00 committed by Alex Schultz
parent fffe30e442
commit 968dd03487
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tripleo_common/image/image_uploader.py
View File

@ -588,8 +588,7 @@ class BaseImageUploader(object):
else:
raise OSError('Log output is not a file.')
except (AttributeError, OSError):
tmp_dir = tempfile.gettempdir()
log_f = os.path.join(tmp_dir, log_name)
log_f = os.path.join('/var/log', log_name)
try:
LOG.info('Ansible action starting')
ansible.AnsiblePlaybookAction(

4
tripleo_common/tests/image/test_image_uploader.py
View File

@ -1311,8 +1311,8 @@ class TestSkopeoImageUploader(base.TestCase):
override_ansible_cfg=(
"[defaults]\n"
"stdout_callback=tripleo_dense\n"
"log_path=%s/tripleo-container-image-prepare-ansible.log\n"
% os.path.dirname(logfile.name)
"log_path="
"/var/log/tripleo-container-image-prepare-ansible.log\n"
)
)