Update patch set 1

Patch Set 1:

(2 comments)

Patch-set: 1
Label: Verified=0
This commit is contained in:
Gerrit User 8042 2016-02-25 16:37:42 +00:00 committed by Gerrit Code Review
parent 532a6caff4
commit 9bca7f2aaa
1 changed files with 38 additions and 0 deletions

View File

@ -0,0 +1,38 @@
{
"comments": [
{
"key": {
"uuid": "bae84128_ecd59b1b",
"filename": "scripts/upgrade-non-controllers.sh",
"patchSetId": 1
},
"lineNbr": 1,
"author": {
"id": 8042
},
"writtenOn": "2016-02-25T16:37:42Z",
"side": 1,
"message": "Only minor detail i have is that perhaps this could be named \"upgrade-non-controller.sh\" (singular) to emphasize the fact that it\u0027s not going to upgrade all non-controllers, but just the one user explicitly asks to upgrade. Otherwise i totally dig the script. +2 but would be nice to update",
"revId": "d511cb7d791f1f47da7c3336ba0591aac6ab60e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bae84128_4c5ac784",
"filename": "scripts/upgrade-non-controllers.sh",
"patchSetId": 1
},
"lineNbr": 21,
"author": {
"id": 8042
},
"writtenOn": "2016-02-25T16:37:42Z",
"side": 1,
"message": "I\u0027m still thinking that the scripts could be in tripleo-common too, and they could be `scp`-ed to the nodes right before running them. That way we can be certain that the nodes always have the latest version of the script. Delivering the script via Heat seems to complicate things a bit (e.g. how do we re-deliver an updated script without retriggering controller update).\n\nIf we come to an agreement on this, this would be done in a separate patch anyway i think.",
"revId": "d511cb7d791f1f47da7c3336ba0591aac6ab60e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}