openstack
/
tripleo-common
Code Issues Proposed changes

Remove ironic-inspector dnsmasq healthcheck 

This check is broken because healthcheck_port uses the user of the
process, but the /proc files accessed are owned by root. This is
probably because dnsmasq starts as root to bind to priviliged port 67,
then drops to the dnsmasq user.

This healthcheck likely doesn't add much value since it is a
self-contained tool which will be bound to the port if it is running.

See https://bugzilla.redhat.com/show_bug.cgi?id=1961237

Change-Id: Ic23e80465356f0a336621008e0a9d5b0c295d816
This commit is contained in:
Steve Baker 2021-07-02 15:38:58 +12:00
parent 12743abaf4
commit a3be15743b
1 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
healthcheck/ironic-inspector
View File

@ -4,18 +4,7 @@
process='dnsmasq'
if pgrep $process; then
listen_address=$(get_config_val /etc/ironic-inspector/inspector.conf DEFAULT listen_address 127.0.0.1)
# Check DHCPv6 port if using IPv6
if [[ $listen_address =~ ":" ]]; then
port="547"
else
port="67"
fi
echo "Checking $process port(s) $port."
if ! healthcheck_port $process $port; then
echo "There is no $process process listening on port(s) $port in the container."
exit 1
fi
exit 0
else
bind_host=$(wrap_ipv6 $(get_config_val /etc/ironic-inspector/inspector.conf DEFAULT listen_address 127.0.0.1))
bind_port=$(get_config_val /etc/ironic-inspector/inspector.conf DEFAULT listen_port 5050)