openstack/tripleo-common
Code Issues Proposed changes

Stop setting IRONIC_API_VERSION and OS_BAREMETAL_API_VERSION in overcloudrc

Browse Source 
Starting with python-ironicclient 2.0.0, this is no longer needed to access
the latest features, as the default API version is now the latest version
supported by both the client and the server.

Change-Id: Icfc631484a500fd7730d807bcc0e87da62895187
Closes-Bug: #1671145
This commit is contained in:
Dmitry Tantsur 2017-11-24 14:55:15 +01:00
parent f46524a016
commit acf06a514a
3 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
releasenotes/notes/ironic-api-version-latest-328a5894677f801d.yaml Normal file
View File

@ -0,0 +1,8 @@
---
upgrade:
- |
The environment variables ``IRONIC_API_VERSION`` and
``OS_BAREMETAL_API_VERSION`` are no longer set in ``overcloudrc``.
Starting with python-ironicclient 2.0.0 this will result in the latest
supported API version to be used. Scripts that rely on a particular API
version behavior must set these versions explicitly.

4
tripleo_common/constants.py
View File

@ -114,10 +114,6 @@ PASSWORD_PARAMETER_NAMES = (
PLAN_NAME_PATTERN = '^[a-zA-Z0-9-]+$'
# The default version of the Bare metal API to set in overcloudrc.
# 1.34 is the latest API version in Ironic Pike supported by ironicclient.
DEFAULT_BAREMETAL_API_VERSION = '1.34'
# The default version of the Image API to set in overcloudrc.
DEFAULT_IMAGE_API_VERSION = '2'

2
tripleo_common/utils/overcloudrc.py
View File

@ -102,8 +102,6 @@ def create_overcloudrc(stack, no_proxy, admin_password):
'OS_PASSWORD': admin_password,
'OS_AUTH_URL': overcloud_endpoint.replace('/v2.0', '') + '/v3',
'OS_IDENTITY_API_VERSION': '3',
'OS_BAREMETAL_API_VERSION': constants.DEFAULT_BAREMETAL_API_VERSION,
'IRONIC_API_VERSION': constants.DEFAULT_BAREMETAL_API_VERSION,
'OS_IMAGE_API_VERSION': constants.DEFAULT_IMAGE_API_VERSION,
'OS_VOLUME_API_VERSION': constants.DEFAULT_VOLUME_API_VERSION,
}