openstack
/
tripleo-common
Code Issues Proposed changes

[queens] Don't use service_facts 

Don't use service_facts to check if NetworkManager is enabled.
We're removing facts usage as it has performance issues and
ansible 2.6 service_facts module does not have 'status'.

Depends-On: https://review.opendev.org/c/openstack/tripleo-quickstart/+/777051
Closes-Bug: #1916459
Change-Id: Iefb3d6b3c4800e6948d44c9419f6690d5220a399
This commit is contained in:
ramishra 2021-02-22 17:28:59 +05:30
parent b7885f0dd6
commit b3183235a9
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
roles/tripleo-bootstrap/tasks/main.yml
View File

@ -11,16 +11,17 @@
rpm -q {{ item }} rpm -q {{ item }}
with_items: "{{ packages_bootstrap }}" with_items: "{{ packages_bootstrap }}"
- name: Populate service facts - name: Check NetworkManager status
service_facts: shell: systemctl is-active NetworkManager.service || systemctl is-enabled NetworkManager.service
failed_when: false
become: true
register: network_manager_enabled
- name: Stop NetworkManager from updating resolv.conf - name: Stop NetworkManager from updating resolv.conf
become: true become: true
when: when:
- ansible_os_family | lower == 'redhat' - network_manager_enabled.rc is defined
- ansible_distribution_major_version | int >= 7 - network_manager_enabled.rc == 0
- "'NetworkManager.service' in ansible_facts.services"
- ansible_facts.services['NetworkManager.service']['status'] == 'enabled'
block: block:
- name: Set 'dns=none' in /etc/NetworkManager/NetworkManager.conf - name: Set 'dns=none' in /etc/NetworkManager/NetworkManager.conf
ini_file: ini_file: