openstack/tripleo-common
Code Issues Proposed changes

Fix tarball generation when downloading logs

Browse Source 
The argument list for the function `create_and_upload_tarball` has
recently changed, and it broke the PrepareDownload action.  An extra
positional argument was added.  We switch our last argument to be a
named one.

Related: https://review.openstack.org/#/c/517610/

Change-Id: Ifa564b2046ca6a304e9f8f82dd1949dc3c127817
Story: #2001916
Task: #14440
This commit is contained in:
Honza Pokorny 2018-04-24 11:26:26 -03:00
parent 859a430750
commit ca0b4ad397
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tripleo_common/actions/logging_to_swift.py
View File

@ -168,7 +168,7 @@ class PrepareLogDownloadAction(base.TripleOAction):
swift, self.logging_container, tmp_dir)
swiftutils.create_and_upload_tarball(
swift_service, tmp_dir, self.downloads_container,
tarball_name, self.delete_after)
tarball_name, delete_after=self.delete_after)
except swiftexceptions.ClientException as err:
msg = "Error attempting an operation on container: %s" % err
return actions.Result(error=msg)