From e284c5f75bc78e5eeb654b0202b752ebd27c6068 Mon Sep 17 00:00:00 2001 From: Bob Fournier Date: Wed, 15 Apr 2020 13:56:01 -0400 Subject: [PATCH] Use healthcheck_port for ironic_inspector_dnsmasq healthcheck ironic_inspector_dnsmasq healthchecks currently use healthcheck_listen() to check if dnsmasq is listening for udp packets on the DHCP port. In Train we are seeing occasional failures with this healthcheck. It may be the same issue as in https://bugs.launchpad.net/tripleo/+bug/1860556, which was resolved for healthcheck_port but not for healthcheck_listen. It appears that this has been redone in master to get away from 'ss' - https://review.opendev.org/#/c/708339/. However, in master healthcheck_listen only works with tcp ports, so the ironic_inspector_dnsmasq healthcheck fails in master too. A better way is to use healthcheck_port for ironic_inspector_dnsmasq healthchecks. Since this is a udp port, this will work with Train and master Change-Id: I16e6d462b0eca60e75eb5b91259575e62f17fe31 Closes-Bug: 1873049 --- healthcheck/ironic-inspector | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/healthcheck/ironic-inspector b/healthcheck/ironic-inspector index 856cb759b..0a9ff6252 100755 --- a/healthcheck/ironic-inspector +++ b/healthcheck/ironic-inspector @@ -12,7 +12,7 @@ if pgrep $process; then port="67" fi echo "Checking $process port(s) $port." - if ! healthcheck_listen $process $port; then + if ! healthcheck_port $process $port; then echo "There is no $process process listening on port(s) $port in the container." exit 1 fi