openstack
/
tripleo-common
Code Issues Proposed changes

Set PROFILE_TASKS_TASK_OUTPUT_LIMIT 

Currently it is set to 0 by default which results in a summary not
being printed at the end of the ansible playbook run. It would
greatly benefit operators if we printed out the top 20 time consuming
tasks at the end of the playbook run.

Conflicts:
    tripleo_common/tests/actions/test_ansible.py

Change-Id: I140fe66091d4e7a710f04da15cc93b7e6bf5742c
Signed-off-by: Sai Sindhur Malleni <smalleni@redhat.com>
(cherry picked from commit ffff7887d4)
This commit is contained in:
Sai Sindhur Malleni 2020-02-07 10:47:41 -05:00 committed by Luke Short
parent c9dffbd20f
commit e5adc226b6
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tripleo_common/actions/ansible.py
View File

@ -395,7 +395,7 @@ class AnsiblePlaybookAction(base.TripleOAction):
self.trash_output = self._kwargs_for_run.pop('trash_output', False)
self.profile_tasks = self._kwargs_for_run.pop('profile_tasks', True)
self.profile_tasks_limit = self._kwargs_for_run.pop(
'profile_tasks_limit', 0)
'profile_tasks_limit', 20)
self.blacklisted_hostnames = self._kwargs_for_run.pop(
'blacklisted_hostnames', [])
self.override_ansible_cfg = self._kwargs_for_run.pop(

6
tripleo_common/tests/actions/test_ansible.py
View File

@ -115,7 +115,7 @@ class AnsiblePlaybookActionTest(base.TestCase):
'ANSIBLE_CONFIG': ansible_config_path,
'ANSIBLE_CALLBACK_WHITELIST': 'tripleo,profile_tasks',
'ANSIBLE_STDOUT_CALLBACK': 'tripleo',
'PROFILE_TASKS_TASK_OUTPUT_LIMIT': '0',
'PROFILE_TASKS_TASK_OUTPUT_LIMIT': '20',
}
python_version = sys.version_info.major
ansible_playbook_cmd = 'ansible-playbook-{}'.format(python_version)
@ -155,7 +155,7 @@ class AnsiblePlaybookActionTest(base.TestCase):
'ANSIBLE_CONFIG': ansible_config_path,
'ANSIBLE_CALLBACK_WHITELIST': 'tripleo,profile_tasks',
'ANSIBLE_STDOUT_CALLBACK': 'tripleo',
'PROFILE_TASKS_TASK_OUTPUT_LIMIT': '0',
'PROFILE_TASKS_TASK_OUTPUT_LIMIT': '20',
}
python_version = sys.version_info.major
ansible_playbook_cmd = 'ansible-playbook-{}'.format(python_version)
@ -195,7 +195,7 @@ class AnsiblePlaybookActionTest(base.TestCase):
'ANSIBLE_CONFIG': ansible_config_path,
'ANSIBLE_CALLBACK_WHITELIST': 'tripleo,profile_tasks',
'ANSIBLE_STDOUT_CALLBACK': 'tripleo',
'PROFILE_TASKS_TASK_OUTPUT_LIMIT': '0',
'PROFILE_TASKS_TASK_OUTPUT_LIMIT': '20',
}
python_version = sys.version_info.major
ansible_playbook_cmd = 'ansible-playbook-{}'.format(python_version)