openstack/tripleo-common
Code Issues Proposed changes

Revert "Set display_skipped_host to no"

Browse Source 
display_skipped_hosts=no has the unfortunate side effect of not showing
the running task name until the task has returned. The reason is b/c the
task name won't be shown at all if all hosts are skipped, but that won't
be known until the task returns.

For long running tasks, this can be quite misleading as the running task
name is not seen until it returns. This makes debugging difficult, and users
don't know what task is actually running until it's completed.

There is an option to show the task name as soon as it starts executing,
but it was not added until ansible-2.9:
https://github.com/ansible/ansible/pull/53819

See also https://github.com/ansible/ansible/issues/51042

This reverts commit 403535c572.

Change-Id: Ia9e291d476d3143b194ce06002a0c1745cf3ef94
This commit is contained in:
James Slagle 2019-11-05 16:42:20 -05:00
parent 26bd0efd26
commit efe21cdecb
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tripleo_common/actions/ansible.py
View File

@ -92,8 +92,6 @@ def write_default_ansible_cfg(work_dir,
config.set('defaults', 'action_plugins', action_plugins_path)
config.set('defaults', 'lookup_plugins', lookups_path)
config.set('defaults', 'filter_plugins', filter_plugins_path)
# suppress tasks if all hosts skip, was previously full_skip callback
config.set('defaults', 'display_skipped_hosts', 'no')
log_path = os.path.join(work_dir, 'ansible.log')
config.set('defaults', 'log_path', log_path)