{ "comments": [ { "key": { "uuid": "9aed3d3a_b1af2329", "filename": "tripleo_common/core/view.py", "patchSetId": 7 }, "lineNbr": 65, "author": { "id": 9712 }, "writtenOn": "2016-02-29T09:06:18Z", "side": 1, "message": "and as ryan pointed out below, we don\u0027t need list() here.", "revId": "b17f87340b97e78a450b3a6efb5dab4bdd3dcb73", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "bae84128_12d7fb23", "filename": "tripleo_common/core/view.py", "patchSetId": 7 }, "lineNbr": 72, "author": { "id": 12321 }, "writtenOn": "2016-02-22T19:00:30Z", "side": 1, "message": "Isn\u0027t this cast redundant?", "revId": "b17f87340b97e78a450b3a6efb5dab4bdd3dcb73", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "9aed3d3a_51be9765", "filename": "tripleo_common/core/view.py", "patchSetId": 7 }, "lineNbr": 72, "author": { "id": 9712 }, "writtenOn": "2016-02-29T09:06:18Z", "side": 1, "message": "Yeah, there is no need for the dict() call here.", "parentUuid": "bae84128_12d7fb23", "revId": "b17f87340b97e78a450b3a6efb5dab4bdd3dcb73", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "9aed3d3a_b1d6ec4c", "filename": "tripleo_common/core/view.py", "patchSetId": 7 }, "lineNbr": 123, "author": { "id": 9712 }, "writtenOn": "2016-02-29T15:21:51Z", "side": 1, "message": "Do we know what the performance impact of the nested depth is? I have been using nested\u003d5 in my tests and with 6 nodes, that gets really slow (30s). So it makes me wonder how 3 will work on a real world deployment of say 20 nodes.\n\nI\u0027m not sure how we know without trying it - but perhaps we should add it as an argument so that the CLI can expose it and users have some control if it is really slow.", "revId": "b17f87340b97e78a450b3a6efb5dab4bdd3dcb73", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, { "key": { "uuid": "9aed3d3a_40a85edb", "filename": "tripleo_common/core/view.py", "patchSetId": 7 }, "lineNbr": 123, "author": { "id": 9712 }, "writtenOn": "2016-02-29T18:50:52Z", "side": 1, "message": "It\u0027s actually taking over 2 mins sometimes for me with 6 nodes.", "parentUuid": "9aed3d3a_b1d6ec4c", "revId": "b17f87340b97e78a450b3a6efb5dab4bdd3dcb73", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false } ] }