bdbce00e31
This patch updates our Popen calls to enable universal newlines for calls that we parse or consume the output for. Without univeral_newlines=True, the output is treated as bytes under python3 which leads to issues later where we are using it as strings. See https://docs.python.org/3/glossary.html#term-universal-newlines Change-Id: I1a9edd0ebac6f0539ac5c33056c442cfcfafb7f3 Related-Blueprint: python3-support
263 lines
9.2 KiB
Python
Executable File
263 lines
9.2 KiB
Python
Executable File
#!/usr/bin/env python
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import argparse
|
|
import logging
|
|
import multiprocessing
|
|
import subprocess
|
|
import sys
|
|
import yaml
|
|
import yum
|
|
|
|
log = logging.getLogger()
|
|
log.setLevel(logging.DEBUG)
|
|
ch = logging.StreamHandler(sys.stdout)
|
|
ch.setLevel(logging.DEBUG)
|
|
formatter = logging.Formatter('%(asctime)s %(levelname)s: %(message)s')
|
|
ch.setFormatter(formatter)
|
|
log.addHandler(ch)
|
|
|
|
|
|
def parse_opts(argv):
|
|
parser = argparse.ArgumentParser("Verify and possibly update rpms in "
|
|
"containers")
|
|
parser.add_argument('-c', '--containers', required=True,
|
|
help="YAML File containing a list of containers to "
|
|
"inspect.")
|
|
parser.add_argument('-p', '--process-count',
|
|
help="Number of processes to use in the pool when "
|
|
"running docker containers.",
|
|
default=multiprocessing.cpu_count())
|
|
parser.add_argument('-u', '--update',
|
|
action='store_true',
|
|
help="Run yum update in any containers that need "
|
|
"updating.",
|
|
default=False)
|
|
parser.add_argument('-k', '--packages', nargs='*',
|
|
help="""List of packages to update, by default all""",
|
|
default=None)
|
|
opts = parser.parse_args(argv[1:])
|
|
return opts
|
|
|
|
|
|
def rm_container(name):
|
|
log.info('Removing container: %s' % name)
|
|
subproc = subprocess.Popen(['/usr/bin/docker', 'rm', name],
|
|
stdout=subprocess.PIPE,
|
|
stderr=subprocess.PIPE,
|
|
universal_newlines=True)
|
|
cmd_stdout, cmd_stderr = subproc.communicate()
|
|
if cmd_stdout:
|
|
log.debug(cmd_stdout)
|
|
if cmd_stderr and \
|
|
cmd_stderr != 'Error response from daemon: ' \
|
|
'No such container: {}\n'.format(name):
|
|
log.debug(cmd_stderr)
|
|
|
|
|
|
def populate_container_rpms_list(container):
|
|
|
|
dcmd = ['/usr/bin/docker', 'run',
|
|
'--user', 'root',
|
|
'--rm',
|
|
container]
|
|
|
|
dcmd.extend(['rpm', '-qa'])
|
|
|
|
log.info('Running docker command: %s' % ' '.join(dcmd))
|
|
|
|
subproc = subprocess.Popen(dcmd, stdout=subprocess.PIPE,
|
|
stderr=subprocess.PIPE,
|
|
universal_newlines=True)
|
|
cmd_stdout, cmd_stderr = subproc.communicate()
|
|
if subproc.returncode != 0:
|
|
log.error('Failed running rpm -qa for %s' % container)
|
|
log.error(cmd_stderr)
|
|
|
|
rpms = cmd_stdout.split("\n")
|
|
|
|
return (subproc.returncode, container, rpms)
|
|
|
|
|
|
def yum_update_container(container, name, packages):
|
|
|
|
container_name = 'yum-update-%s' % name
|
|
|
|
rm_container(container_name)
|
|
|
|
# Get the command from the original so that when we commit
|
|
# we can ensure the command doesn't get updated.
|
|
dcmd = ['/usr/bin/docker', 'inspect',
|
|
'--format', '{{json .Config.Cmd}}',
|
|
container]
|
|
subproc = subprocess.Popen(dcmd, stdout=subprocess.PIPE,
|
|
stderr=subprocess.PIPE,
|
|
universal_newlines=True)
|
|
cmd_stdout, cmd_stderr = subproc.communicate()
|
|
container_cmd = cmd_stdout
|
|
log.info('Original container command: %s' % container_cmd)
|
|
|
|
dcmd = ['/usr/bin/docker', 'run',
|
|
'--user', 'root',
|
|
'--net', 'host',
|
|
'--volume', '/etc/yum.repos.d:/etc/yum.repos.d',
|
|
'--volume', '/opt:/opt',
|
|
'--name', container_name,
|
|
container]
|
|
|
|
dcmd.extend(['yum', '-y', 'update'])
|
|
if packages:
|
|
dcmd.extend(packages)
|
|
|
|
retry_count = 1
|
|
while True:
|
|
log.info('Running docker command: %s' % ' '.join(dcmd))
|
|
|
|
subproc = subprocess.Popen(dcmd,
|
|
stdout=subprocess.PIPE,
|
|
stderr=subprocess.PIPE,
|
|
universal_newlines=True)
|
|
cmd_stdout, cmd_stderr = subproc.communicate()
|
|
log.info(cmd_stdout)
|
|
if subproc.returncode != 0:
|
|
log.error('Failed running yum update for %s; try number %d' %
|
|
(container, retry_count))
|
|
log.error(cmd_stderr)
|
|
rm_container(container_name)
|
|
if retry_count >= 3:
|
|
log.error('Tried %d times to update %s; giving up.' %
|
|
(retry_count, container))
|
|
return (subproc.returncode, container)
|
|
else:
|
|
break
|
|
retry_count += 1
|
|
|
|
dcmd = ['/usr/bin/docker', 'commit',
|
|
'-m', 'automatic yum update',
|
|
'--change', 'CMD %s' % container_cmd,
|
|
container_name,
|
|
container]
|
|
log.info('Running docker command: %s' % ' '.join(dcmd))
|
|
|
|
subproc = subprocess.Popen(dcmd, stdout=subprocess.PIPE,
|
|
stderr=subprocess.PIPE,
|
|
universal_newlines=True)
|
|
cmd_stdout, cmd_stderr = subproc.communicate()
|
|
if subproc.returncode != 0:
|
|
log.error('Failed running docker commit for %s' % container)
|
|
log.error(cmd_stderr)
|
|
|
|
dcmd = ['/usr/bin/docker', 'push',
|
|
container]
|
|
log.info('Running docker command: %s' % ' '.join(dcmd))
|
|
|
|
subproc = subprocess.Popen(dcmd, stdout=subprocess.PIPE,
|
|
stderr=subprocess.PIPE,
|
|
universal_newlines=True)
|
|
cmd_stdout, cmd_stderr = subproc.communicate()
|
|
if subproc.returncode != 0:
|
|
log.error('Failed running docker push for %s' % container)
|
|
log.error(cmd_stderr)
|
|
rm_container(container_name)
|
|
|
|
return (subproc.returncode, container)
|
|
|
|
|
|
def get_available_rpms():
|
|
available_rpms = {}
|
|
yb = yum.YumBase()
|
|
yb.setCacheDir()
|
|
pkglist = yb.pkgSack.returnPackages()
|
|
for pkg in pkglist:
|
|
# This gives us a string the same as rpm -qa
|
|
available_rpms[pkg.name + '-' + pkg.vra] = 1
|
|
return available_rpms
|
|
|
|
|
|
def get_container_list(container_file):
|
|
container_list = []
|
|
with open(container_file) as cf:
|
|
data = yaml.safe_load(cf.read()).get('container_images', [])
|
|
for image_info in data:
|
|
print('image_info: %s' % image_info)
|
|
container_list.append(image_info['imagename'])
|
|
return container_list
|
|
|
|
|
|
if __name__ == '__main__':
|
|
opts = parse_opts(sys.argv)
|
|
|
|
# Get a list of all the docker containers we need to inspect.
|
|
docker_containers = get_container_list(opts.containers)
|
|
|
|
# Load up available rpms as a hash containing the latest versions of rpms.
|
|
available_rpms = get_available_rpms()
|
|
|
|
# Holds all the information for each process to consume.
|
|
# Instead of starting them all linearly we run them using a process
|
|
# pool.
|
|
process_map = []
|
|
for container in docker_containers:
|
|
process_map.append(container)
|
|
|
|
# This is what we're after here, a hash keyed by containers, each entry
|
|
# containing a list of rpms in that container.
|
|
container_rpms = {}
|
|
success = True
|
|
# Fire off processes to perform each rpm list.
|
|
p = multiprocessing.Pool(int(opts.process_count))
|
|
ret = list(p.map(populate_container_rpms_list, process_map))
|
|
for returncode, container, rpms in ret:
|
|
container_rpms[container] = rpms
|
|
if returncode != 0:
|
|
log.error('ERROR running rpm query in container: %s' % container)
|
|
success = False
|
|
|
|
if not success:
|
|
sys.exit(1)
|
|
|
|
container_update_list = {}
|
|
|
|
for container in container_rpms:
|
|
for rpm in container_rpms[container]:
|
|
if len(rpm) > 0 and not rpm.startswith('gpg-pubkey-') and \
|
|
rpm not in available_rpms:
|
|
if container not in container_update_list:
|
|
container_update_list[container] = []
|
|
container_update_list[container].append(rpm)
|
|
|
|
for container in container_update_list:
|
|
log.info("Container needs updating: %s" % container)
|
|
for rpm in container_update_list[container]:
|
|
log.info(" rpm: %s" % rpm)
|
|
|
|
log.info('*** %d of %d containers require updates ***' %
|
|
(len(container_update_list), len(docker_containers)))
|
|
|
|
# And finally update the containers if required
|
|
if opts.update:
|
|
process_map = []
|
|
name = 0
|
|
for container in container_update_list:
|
|
process_map.append([container, str(name), opts.packages])
|
|
name += 1
|
|
|
|
ret = list(p.map(yum_update_container, process_map))
|
|
for returncode, container in ret:
|
|
if returncode != 0:
|
|
log.error('ERROR running yum update in container %s' %
|
|
container)
|
|
success = False
|
|
if not success:
|
|
sys.exit(1)
|