tripleo-common/24556c82451a3fedbd79f3fed1ca0d4f8b3a0c20

{
  "comments": [
    {
      "key": {
        "uuid": "9aed3d3a_cd5c2728",
        "filename": "scripts/upgrade-non-controller.sh",
        "patchSetId": 3
      },
      "lineNbr": 19,
      "author": {
        "id": 6796
      },
      "writtenOn": "2016-02-26T10:43:32Z",
      "side": 1,
      "message": "maybe we can remove \u0027at ...\u0027 entirely",
      "revId": "24556c82451a3fedbd79f3fed1ca0d4f8b3a0c20",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "9aed3d3a_d0f83ce8",
        "filename": "scripts/upgrade-non-controller.sh",
        "patchSetId": 3
      },
      "lineNbr": 19,
      "author": {
        "id": 8449
      },
      "writtenOn": "2016-02-26T10:51:30Z",
      "side": 1,
      "message": "why, I expect we will be documenting this at some point in tripleo-docs and would like to point at it",
      "parentUuid": "9aed3d3a_cd5c2728",
      "revId": "24556c82451a3fedbd79f3fed1ca0d4f8b3a0c20",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "9aed3d3a_6d4cfb70",
        "filename": "scripts/upgrade-non-controller.sh",
        "patchSetId": 3
      },
      "lineNbr": 21,
      "author": {
        "id": 6796
      },
      "writtenOn": "2016-02-26T10:43:32Z",
      "side": 1,
      "message": "delivered",
      "revId": "24556c82451a3fedbd79f3fed1ca0d4f8b3a0c20",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "9aed3d3a_10dbc47d",
        "filename": "scripts/upgrade-non-controller.sh",
        "patchSetId": 3
      },
      "lineNbr": 21,
      "author": {
        "id": 8449
      },
      "writtenOn": "2016-02-26T10:51:30Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "9aed3d3a_6d4cfb70",
      "revId": "24556c82451a3fedbd79f3fed1ca0d4f8b3a0c20",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "9aed3d3a_0d93af5c",
        "filename": "scripts/upgrade-non-controller.sh",
        "patchSetId": 3
      },
      "lineNbr": 29,
      "author": {
        "id": 6796
      },
      "writtenOn": "2016-02-26T10:43:32Z",
      "side": 1,
      "message": "doesn\u0027t this path conflict with Ic6115fc8cf5320abfcf500112ff563bde8b88661 ?",
      "revId": "24556c82451a3fedbd79f3fed1ca0d4f8b3a0c20",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "9aed3d3a_70e85011",
        "filename": "scripts/upgrade-non-controller.sh",
        "patchSetId": 3
      },
      "lineNbr": 29,
      "author": {
        "id": 8042
      },
      "writtenOn": "2016-02-26T10:47:27Z",
      "side": 1,
      "message": "It must be the same, actually. Here we execute the script which the t-h-t patch delivers.",
      "parentUuid": "9aed3d3a_0d93af5c",
      "revId": "24556c82451a3fedbd79f3fed1ca0d4f8b3a0c20",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "9aed3d3a_10f744d4",
        "filename": "scripts/upgrade-non-controller.sh",
        "patchSetId": 3
      },
      "lineNbr": 29,
      "author": {
        "id": 8449
      },
      "writtenOn": "2016-02-26T10:51:30Z",
      "side": 1,
      "message": "No. the idea is that we will deliver the (non-controller) nodes upgrade script to /root/tripleo_upgrade_node.sh as part of the controller upgrade workflow as in that patch you refer to.\n\nThe (latest) upgrades workflow is that the operator will invoke those scripts, after the controllers are upgraded, for each non-controller node, using this script, here.",
      "parentUuid": "9aed3d3a_0d93af5c",
      "revId": "24556c82451a3fedbd79f3fed1ca0d4f8b3a0c20",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "9aed3d3a_8d7e9fe2",
        "filename": "scripts/upgrade-non-controller.sh",
        "patchSetId": 3
      },
      "lineNbr": 70,
      "author": {
        "id": 6796
      },
      "writtenOn": "2016-02-26T10:43:32Z",
      "side": 1,
      "message": "would be useful for this to go into common?",
      "revId": "24556c82451a3fedbd79f3fed1ca0d4f8b3a0c20",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "9aed3d3a_f0b460f3",
        "filename": "scripts/upgrade-non-controller.sh",
        "patchSetId": 3
      },
      "lineNbr": 70,
      "author": {
        "id": 8449
      },
      "writtenOn": "2016-02-26T10:51:30Z",
      "side": 1,
      "message": "I expect doing that, and then revising every invocation of \u0027echo\u0027 in the various functions here would stand up by itself as a follow on patch. Trying to add it here would be messy and not make sense imo.",
      "parentUuid": "9aed3d3a_8d7e9fe2",
      "revId": "24556c82451a3fedbd79f3fed1ca0d4f8b3a0c20",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "9aed3d3a_4de3f7a3",
        "filename": "scripts/upgrade-non-controller.sh",
        "patchSetId": 3
      },
      "lineNbr": 76,
      "author": {
        "id": 6796
      },
      "writtenOn": "2016-02-26T10:43:32Z",
      "side": 1,
      "message": "shall we tell people to source stackrc if they haven\u0027t?",
      "revId": "24556c82451a3fedbd79f3fed1ca0d4f8b3a0c20",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "9aed3d3a_304c0842",
        "filename": "scripts/upgrade-non-controller.sh",
        "patchSetId": 3
      },
      "lineNbr": 76,
      "author": {
        "id": 8042
      },
      "writtenOn": "2016-02-26T10:47:27Z",
      "side": 1,
      "message": "This might be a worthwhile add. Personally i don\u0027t consider this a blocker, can be added subsequently too.",
      "parentUuid": "9aed3d3a_4de3f7a3",
      "revId": "24556c82451a3fedbd79f3fed1ca0d4f8b3a0c20",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "9aed3d3a_f082a0ff",
        "filename": "scripts/upgrade-non-controller.sh",
        "patchSetId": 3
      },
      "lineNbr": 76,
      "author": {
        "id": 8449
      },
      "writtenOn": "2016-02-26T10:51:30Z",
      "side": 1,
      "message": "no, i think it should fail and they will know why. I thought about adding a \u0027function source_stackrc like we have in tripleo.sh but I really dont want _anything_ extra here. Bash gets very messy very quickly and I would like to keep this as short and simple as possible.",
      "parentUuid": "9aed3d3a_4de3f7a3",
      "revId": "24556c82451a3fedbd79f3fed1ca0d4f8b3a0c20",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    }
  ]
}