efa167ddfa
This is a follow-up from [1] which underlined that the code lacks even basic coverage as it allow
us to introduce a costly regression which could have being detected by pylint no-member test.
- enables pylint with most checks temporary disabled, so we have time
to address them gradually
- fixes few minor issues reported by the tool
- adds skips for some known "no-member" errors but avoids adding it to the exclude list, as this
in order to prevent further regressions.
- once landed we can easily address the temporary disabled errors, one by one. In fact this is could
prove as a very good learning experience for newer team members. They can start by removing on
random exclusion and fixing it. As a hint: leave the missing docstrings for the end, some problems
are more important to fix first.
1: https://review.opendev.org/c/openstack/tripleo-common/+/762892/6/tripleo_common/image/builder/buildah.py
Change-Id: I10ab0cbfbaab77b9208e9a5d74d59eb041cb16ee
(cherry picked from commit 13ac87ba36)
67 lines
1.6 KiB
INI
67 lines
1.6 KiB
INI
[MESSAGES CONTROL]
|
|
|
|
disable =
|
|
# TODO(ssbarnea): remove temporary skips adding during initial adoption:
|
|
arguments-differ,
|
|
attribute-defined-outside-init,
|
|
broad-except,
|
|
consider-iterating-dictionary,
|
|
consider-merging-isinstance,
|
|
consider-using-dict-comprehension,
|
|
consider-using-in,
|
|
consider-using-set-comprehension,
|
|
dangerous-default-value,
|
|
duplicate-code,
|
|
fixme,
|
|
global-statement,
|
|
import-error,
|
|
inconsistent-return-statements,
|
|
invalid-name,
|
|
logging-format-interpolation,
|
|
logging-not-lazy,
|
|
lost-exception,
|
|
missing-class-docstring,
|
|
missing-function-docstring,
|
|
missing-module-docstring,
|
|
no-else-break,
|
|
no-else-continue,
|
|
no-else-raise,
|
|
no-else-return,
|
|
no-self-use,
|
|
no-value-for-parameter,
|
|
protected-access,
|
|
raise-missing-from,
|
|
redefined-argument-from-local,
|
|
redefined-builtin,
|
|
redefined-outer-name,
|
|
simplifiable-if-statement,
|
|
super-init-not-called,
|
|
super-with-arguments,
|
|
superfluous-parens,
|
|
too-few-public-methods,
|
|
too-many-ancestors,
|
|
too-many-arguments,
|
|
too-many-branches,
|
|
too-many-instance-attributes,
|
|
too-many-lines,
|
|
too-many-locals,
|
|
too-many-nested-blocks,
|
|
too-many-public-methods,
|
|
too-many-return-statements,
|
|
too-many-statements,
|
|
try-except-raise,
|
|
unidiomatic-typecheck,
|
|
unnecessary-comprehension,
|
|
unnecessary-pass,
|
|
unsubscriptable-object,
|
|
unused-argument,
|
|
unused-variable,
|
|
useless-else-on-loop,
|
|
useless-object-inheritance,
|
|
useless-super-delegation,
|
|
wrong-import-order,
|
|
wrong-import-position
|
|
|
|
[REPORTS]
|
|
output-format = colorized
|