tripleo-common/tripleo_common/image/builder
Kevin Carter 0be1be779a Ensure we're raising proper exceptions
This change ensures our use of the `process.execute` method from
"oslo_concurrency" always checks the return codes of a given command.
While the library is assumed to do this already, this change
enforces our expected behavior.

We're also changing our use of futures to return when there's
an exception. The build_all method was blocking until all
jobs were completed. Blocking on pipeline completion results
in us masking exceptions that may be raised duing the job
execution. To ensure we're capturing errors in our build
process the wait function now return on the first exception;
More on the futures constants can be seen here:[0]. The
return values will now be evaluated to ensure all jobs
completed successfully.

Unit tests have been added to ensure we're not breaking the
build all method and that it raise appropriate exceptions
when errors are encountered.

[0] - https://docs.python.org/3/library/concurrent.futures.html#module-functions

Related-Bug: #1836265
Change-Id: Ia05140142fa59e5b252cd92801244e4fc02f4bbc
Signed-off-by: Kevin Carter <kecarter@redhat.com>
2019-07-15 08:41:16 -05:00
..
__init__.py Support for Buildah in kolla_builder 2019-02-14 13:34:51 +00:00
base.py Support for Buildah in kolla_builder 2019-02-14 13:34:51 +00:00
buildah.py Ensure we're raising proper exceptions 2019-07-15 08:41:16 -05:00