openstack
/
tripleo-heat-templates
Code Issues Proposed changes

Stop upgrade if a task on one node fails 

When we were upgrading multiple nodes at the same time,
e.g. controllers, and a taks on one of the nodes failed, the other
nodes would keep upgrading. This is undersirable and can be fixed by
adding any_errors_fatal to the Ansible plays.

Change-Id: Iad2b5e32e955da41af4d2b8dd8ad8aa1eb5dffa9
Closes-Bug: #1804468
(cherry picked from commit 021d1b1efb)
This commit is contained in:
Jiri Stransky 2018-11-21 15:48:53 +01:00
parent 45a6f6d7de
commit 027493c99f
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
common/deploy-steps.j2
View File

@ -619,6 +619,7 @@ outputs:
name: Run update
serial: 1
gather_facts: no
any_errors_fatal: yes
tasks:
- include_tasks: update_steps_tasks.yaml
with_sequence: start=0 end={{update_steps_max-1}}
@ -720,6 +721,7 @@ outputs:
name: Run pre-upgrade rolling tasks
serial: 1
gather_facts: no
any_errors_fatal: yes
tasks:
- include_tasks: pre_upgrade_rolling_steps_tasks.yaml
with_sequence: start=0 end={{pre_upgrade_rolling_steps_max-1}}
@ -737,6 +739,7 @@ outputs:
DEPLOY_TARGET_HOST: {get_param: deployment_target_hosts}
template: |
- hosts: DEPLOY_TARGET_HOST
any_errors_fatal: yes
tasks:
- include_tasks: upgrade_steps_tasks.yaml
with_sequence: start=0 end={{upgrade_steps_max-1}}
@ -754,6 +757,7 @@ outputs:
DEPLOY_TARGET_HOST: {get_param: deployment_target_hosts}
template: |
- hosts: DEPLOY_TARGET_HOST
any_errors_fatal: yes
tasks:
- include_tasks: post_upgrade_steps_tasks.yaml
with_sequence: start=0 end={{post_upgrade_steps_max-1}}
@ -823,6 +827,7 @@ outputs:
DEPLOY_TARGET_HOST: {get_param: deployment_target_hosts}
template: |
- hosts: DEPLOY_TARGET_HOST
any_errors_fatal: yes
tasks:
- set_fact:
releases: {get_param: [FastForwardUpgradeReleases]}