From e8a2dcbb8659c764ec6f68fb2a73fc7bbb575756 Mon Sep 17 00:00:00 2001
From: Jose Luis Franco Arza <jfrancoa@redhat.com>
Date: Thu, 27 Feb 2020 18:14:24 +0100
Subject: [PATCH] Add always tags for hieradata render in external upgrade.

When executing the external-upgrade command, if some of the
external_upgrade_tasks make use of the all_nodes vars (*_short_node_names
for example) then the command fails as these variables weren't
rendered. This only happens when we run the external-upgrade command
passing --tags, as the facts tags are being skipped.

This patch adds the always tags into those tasks which miss it for
external_upgrade_steps_playbook.yaml.

Change-Id: I0913df554b75d25215d5ae6547b939ad0356df3c
---
 common/deploy-steps-playbooks-common.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/common/deploy-steps-playbooks-common.yaml b/common/deploy-steps-playbooks-common.yaml
index 98cf637ac4..f021904678 100644
--- a/common/deploy-steps-playbooks-common.yaml
+++ b/common/deploy-steps-playbooks-common.yaml
@@ -52,6 +52,7 @@
       tripleo_all_nodes_data:
   tags:
     - facts
+    - always
 
 - hosts: "{{ deploy_target_host }}"
   name: Set all_nodes data as group_vars for overcloud
@@ -64,3 +65,4 @@
       when: not ansible_check_mode|bool
   tags:
     - facts
+    - always