openstack/tripleo-heat-templates
Code Issues Proposed changes

Disable sync_power_state_interval in containerized undercloud

Browse Source 
On the non containerized undercloud we had the following snippet:
"""
nova_config {
  'DEFAULT/sync_power_state_interval': value => hiera('nova_sync_power_state_interval');
}

nova_sync_power_state_interval: -1
"""
The reasons for which were described in: https://launchpad.net/bugs/1552842.
This setting has been lost when we moved to containerized undercloud.
Let's add a new NovaSyncPowerStateInterval parameter that is set to 0
(meaning uses the default) and set it to -1 on the undercloud.

With this patch we have on the undercloud:
undercloud: http://logs.openstack.org/23/599423/1/check/tripleo-ci-centos-7-undercloud-containers/73a1323/logs/undercloud/var/log/config-data/nova/etc/nova/nova.conf.txt.gz:
sync_power_state_interval=-1

And on the overcloud:
https://logs.rdoproject.org/23/599423/1/openstack-check/legacy-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-master/d372ea8/logs/overcloud-controller-0/var/log/config-data/nova/etc/nova/nova.conf.txt.gz
sync_power_state_interval=0

Reported-By: Marian Krcmari <mkrcmari@redhat.com>
Co-Authored-By: Emilien Macchi <emilien@redhat.com>

Change-Id: Ifc817ba77187d454c24090c93461b1edad9fe7c4
Closes-Bug: #1790504
This commit is contained in:
Michele Baldessari 2018-09-03 17:05:27 +02:00 committed by Emilien Macchi
parent 3ad979ac72
commit 0be27ee963
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
environments/undercloud.yaml
View File

@ -60,6 +60,7 @@ parameter_defaults:
# Ironic to be disabled in the case of multiple deployment failures.
NovaAutoDisabling: '0'
NovaCorsAllowedOrigin: '*'
NovaSyncPowerStateInterval: -1
NeutronDhcpAgentsPerNetwork: 2
HeatConvergenceEngine: true
HeatCorsAllowedOrigin: '*'

7
puppet/services/nova-base.yaml
View File

@ -195,6 +195,12 @@ parameters:
default: ''
tags:
- role_specific
NovaSyncPowerStateInterval:
type: number
description:
Interval to sync power states between the database and the hypervisor. Set
to -1 to disable. Setting this to 0 will run at the default rate.
default: 0
RpcPort:
default: 5672
description: The network port for messaging backend
@ -343,6 +349,7 @@ outputs:
nova::cron::purge_shadow_tables::age: {get_param: NovaCronPurgeShadowTablesAge}
nova::cron::purge_shadow_tables::verbose: {get_param: NovaCronPurgeShadowTablesVerbose}
nova::cron::purge_shadow_tables::all_cells: {get_param: NovaCronPurgeShadowTablesAllCells}
nova::compute::sync_power_state_interval: {get_param: NovaSyncPowerStateInterval}
- get_attr: [RoleParametersValue, value]
-
if: