From 15ffac7fa04d9b78e46156babe797a3353b209a6 Mon Sep 17 00:00:00 2001 From: Bogdan Dobrelya Date: Wed, 23 Sep 2020 09:13:24 +0200 Subject: [PATCH] Clear cached facts based on the tag as well Facts gathering comes next after clearing the cached ones. Facts will be gathered if --tags facts was specified. But cached facts get cleared always, even w/o that tag. In DCN deployments that may bring errors that can be avoided with ansible-playbook-command.sh --tags facts. That is because fact caching needs to be updated when running outside of the overcloud. Fix this inconsistency so that the facts never cleared nor gathered until the facts tag has been used explicitly. Change-Id: I0ef544a18ec868321ebf51a99051b1ed982cd677 Related-bug: #1896620 Related-bug: #1884654 Signed-off-by: Bogdan Dobrelya (cherry picked from commit d9ed99b5d988908bae5a49e27447d7782b23d2d5) --- common/deploy-steps-playbooks-common.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/deploy-steps-playbooks-common.yaml b/common/deploy-steps-playbooks-common.yaml index 37b9b7d218..b4f4e0dc58 100644 --- a/common/deploy-steps-playbooks-common.yaml +++ b/common/deploy-steps-playbooks-common.yaml @@ -2,6 +2,8 @@ name: Clear cached facts tasks: - meta: clear_facts + tags: + - facts - hosts: "{{ deploy_source_host }}" name: Gather facts from undercloud