From 205ac0f123b598fa292335d05519fd59e160ed39 Mon Sep 17 00:00:00 2001 From: Jose Luis Franco Arza Date: Wed, 4 Sep 2019 11:04:53 +0200 Subject: [PATCH] Run facts gathering always for upgrades. Up to now, each of the upgrade steps to gather facts from the Undercloud and Overcloud nodes did contain a tag named facts. This allowed us to run the facts gathering at will, however there is a problem with the upgrade_tasks. As it is allowed to pass a specific tag during its execution. So, if the task passed is different than facts, for example system_upgrade, then the facts gathering tasks wont be executed and the upgrade tasks will fail when trying to access some of the ansible facts (as it could be ansible_hostname). The solution for this is to run always the facts gathering, no matter what tag is being passed we'll have the facts available during the execution. Change-Id: Ibee072bec9916804163dab29e164eb1423cd08f8 --- common/deploy-steps.j2 | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/common/deploy-steps.j2 b/common/deploy-steps.j2 index 0795dd8346..05265c9d2d 100644 --- a/common/deploy-steps.j2 +++ b/common/deploy-steps.j2 @@ -1086,14 +1086,12 @@ outputs: name: Gather facts from undercloud gather_facts: yes become: false - tags: - - facts + tags: always - hosts: DEPLOY_TARGET_HOST name: Gather facts from overcloud gather_facts: yes - tags: - - facts + tags: always - hosts: all name: Load global variables