diff --git a/deployment/nova/nova-compute-container-puppet.yaml b/deployment/nova/nova-compute-container-puppet.yaml index 30de4d93e1..d4478dbb95 100644 --- a/deployment/nova/nova-compute-container-puppet.yaml +++ b/deployment/nova/nova-compute-container-puppet.yaml @@ -855,18 +855,12 @@ outputs: - resume_guests_state_on_host_boot_enabled|bool - container_cli == 'docker' block: - - name: make sure libvirt-client is installed - when: resume_guests_state_on_host_boot_enabled|bool - package: - name: libvirt-client - state: present - name: libvirt-guests unit to stop nova_compute container before shutdown VMs copy: dest: /etc/systemd/system/libvirt-guests.service content: | [Unit] Description=Suspend/Resume Running libvirt Guests - Requires=virt-guest-shutdown.target After=network.target After=time-sync.target After=virt-guest-shutdown.target @@ -877,12 +871,12 @@ outputs: Documentation=https://libvirt.org [Service] - EnvironmentFile=-/etc/sysconfig/libvirt-guests + EnvironmentFile=-/var/lib/config-data/puppet-generated/nova_libvirt/etc/sysconfig/libvirt-guests # Hack just call traditional service until we factor # out the code - ExecStart=/usr/libexec/libvirt-guests.sh start + ExecStart=/bin/{{container_cli}} exec nova_libvirt /bin/sh -x /usr/libexec/libvirt-guests.sh start ExecStop=/bin/{{container_cli}} stop nova_compute - ExecStop=/usr/libexec/libvirt-guests.sh stop + ExecStop=/bin/{{container_cli}} exec nova_libvirt /bin/sh -x /usr/libexec/libvirt-guests.sh stop Type=oneshot RemainAfterExit=yes StandardOutput=journal+console @@ -894,7 +888,6 @@ outputs: systemd: name: libvirt-guests enabled: yes - state: started daemon_reload: yes - name: install tripleo_nova_libvirt_guests systemd unit file (podman) when: @@ -905,7 +898,6 @@ outputs: systemd: name: libvirt-guests enabled: no - state: stopped masked: yes daemon_reload: yes - name: libvirt-guests unit to stop nova_compute container before shutdown VMs diff --git a/deployment/nova/nova-libvirt-container-puppet.yaml b/deployment/nova/nova-libvirt-container-puppet.yaml index c700644c60..5709fa57fe 100644 --- a/deployment/nova/nova-libvirt-container-puppet.yaml +++ b/deployment/nova/nova-libvirt-container-puppet.yaml @@ -554,7 +554,6 @@ outputs: list_join: - "\n" - - include tripleo::profile::base::nova::libvirt - - include tripleo::profile::base::nova::compute::libvirt_guests - {get_attr: [MySQLClient, role_data, step_config]} config_image: {get_param: ContainerNovaLibvirtConfigImage} kolla_config: diff --git a/deployment/nova/nova-libvirt-guests-container-puppet.yaml b/deployment/nova/nova-libvirt-guests-container-puppet.yaml index d0cc11fa59..8b0e134b49 100644 --- a/deployment/nova/nova-libvirt-guests-container-puppet.yaml +++ b/deployment/nova/nova-libvirt-guests-container-puppet.yaml @@ -30,6 +30,9 @@ parameters: default: {} description: Parameters specific to the role type: json + ContainerNovaLibvirtConfigImage: + description: The container image to use for the nova_libvirt config_volume + type: string NovaResumeGuestsStateOnHostBoot: default: false description: Whether to start running instance on compute host reboot @@ -67,5 +70,9 @@ outputs: value: service_name: nova_libvirt_guests config_settings: {get_attr: [RoleParametersValue, value]} - step_config: | - include ::tripleo::profile::base::nova::compute::libvirt_guests + puppet_config: + config_volume: nova_libvirt + puppet_tags: libvirtd_config,nova_config,file,libvirt_tls_password + step_config: | + include ::tripleo::profile::base::nova::compute::libvirt_guests + config_image: {get_param: ContainerNovaLibvirtConfigImage}