openstack/tripleo-heat-templates
Code Issues Proposed changes

rename rsyslogd service to rsyslog and deal with lack of reload.

Browse Source 
Overlcloud deployment fails during the "Reload services" TASK:

TASK [Reload services] *********************************************************
Friday 15 March 2019 07:51:43 +0000 (0:00:00.560) 0:02:53.361 **********
skipping: [controller-0] => (item=rsyslogd) => {"changed": false, "item": "rsyslogd", "skip_reason": "Conditional result was False"}
skipping: [controller-0] => (item=crond) => {"changed": false, "item": "crond", "skip_reason": "Conditional result was False"}
skipping: [controller-1] => (item=rsyslogd) => {"changed": false, "item": "rsyslogd", "skip_reason": "Conditional result was False"}
skipping: [controller-1] => (item=crond) => {"changed": false, "item": "crond", "skip_reason": "Conditional result was False"}
skipping: [controller-2] => (item=rsyslogd) => {"changed": false, "item": "rsyslogd", "skip_reason": "Conditional result was False"}
skipping: [controller-2] => (item=crond) => {"changed": false, "item": "crond", "skip_reason": "Conditional result was False"}
failed: [compute-0] (item=rsyslogd) => {"changed": false, "item": "rsyslogd", "msg": "Could not find the requested service rsyslogd: host"}
....

Checking "compute-0" it looks like the service name is "rsyslog":

root@compute-0 ~]# systemctl |grep rsys
  rsyslog.service

Simply renaming the service is not sufficient, as the unit file does not
support the reload OP:

[Service]
Type=notify
EnvironmentFile=-/etc/sysconfig/rsyslog
ExecStart=/usr/sbin/rsyslogd -n $SYSLOGD_OPTIONS
UMask=0066
StandardOutput=null
Restart=on-failure

Lacking better options we need to restart rsyslog.

Change-Id: I3f666455a9c5d95536ec801cee86f83bef80fa81
Closes-Bug: #1820166
This commit is contained in:
Luca Miccini 2019-03-15 09:11:15 +01:00
parent 0bb76dc9fc
commit 256d763d4c
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
deployment/time/timezone-baremetal-ansible.yaml
View File

@ -48,11 +48,11 @@ outputs:
timezone:
name: "{{ timezone }}"
register: timezone_result
- name: Reload services
- name: Restart services
service:
name: "{{ item }}"
state: reloaded
state: restarted
with_items:
- rsyslogd
- rsyslog
- crond
when: timezone_result.changed