Merge "Add ability to manage irqbalance on compute per role" into stable/train

deployment/nova/nova-compute-container-puppet.yaml

@@ -406,6 +406,13 @@ parameters:
     default: 86400
     tags:
       - role_specific
+  NovaComputeDisableIrqBalance:
+    default: false
+    description: Whether to disable irqbalance on compute nodes or not. Especially
+                 in Realtime Compute role one wants to keep it disabled.
+    type: boolean
+    tags:
+      - role_specific
 
   # DEPRECATED: the following options are deprecated and are currently maintained
   # for backwards compatibility. They will be removed in future release.
@@ -505,6 +512,7 @@ resources:
               nova::compute::libvirt::pmem_namespaces: NovaPMEMMappings
               nova_pmem_namespaces: NovaPMEMNamespaces
               nova::compute::libvirt::remove_unused_original_minimum_age_seconds: NovaImageCacheTTL
+              compute_disable_irqbalance: NovaComputeDisableIrqBalance
             - values: {get_param: [RoleParameters]}
           - values:
               NovaVcpuPinSet: {get_param: NovaVcpuPinSet}
@@ -579,6 +587,7 @@ resources:
               NovaPMEMMappings: {get_param: NovaPMEMMappings}
               NovaPMEMNamespaces: {get_param: NovaPMEMNamespaces}
               NovaImageCacheTTL: {get_param: NovaImageCacheTTL}
+              NovaComputeDisableIrqBalance: {get_param: NovaComputeDisableIrqBalance}
 
 conditions:
   insecure_registry_is_empty: {equals : [{get_param: DockerInsecureRegistryAddress}, []]}
@@ -1062,6 +1071,15 @@ outputs:
               with_items:
                 - ksm.service
                 - ksmtuned.service
+          - name: Is irqbalance enabled
+            set_fact:
+              compute_irqbalance_disabled: {get_attr: [RoleParametersValue, value, compute_disable_irqbalance]}
+          - name: disable irqbalance service on compute
+            when: compute_irqbalance_disabled|bool
+            service:
+              name: irqbalance.service
+              state: stopped
+              enabled: no
       deploy_steps_tasks:
         - name: validate nova compute container state
           when:

roles/ComputeOvsDpdkRT.yaml

@@ -19,6 +19,7 @@
     NovaLibvirtRxQueueSize: 1024
     NovaLibvirtTxQueueSize: 1024
     NovaLibvirtMemStatsPeriodSeconds: 0
+    NovaComputeDisableIrqBalance: True
   update_serial: 25
   ServicesDefault:
     - OS::TripleO::Services::Aide

roles/ComputeOvsDpdkSriovRT.yaml

@@ -16,6 +16,7 @@
     NovaLibvirtRxQueueSize: 1024
     NovaLibvirtTxQueueSize: 1024
     NovaLibvirtMemStatsPeriodSeconds: 0
+    NovaComputeDisableIrqBalance: True
   update_serial: 25
   ServicesDefault:
     - OS::TripleO::Services::Aide

roles/ComputeRealTime.yaml

@@ -25,6 +25,7 @@
     NovaComputeCpuDedicatedSet: ""  # real-time nodes
     NovaComputeCpuSharedSet: ""     #
     NovaLibvirtMemStatsPeriodSeconds: 0
+    NovaComputeDisableIrqBalance: True
   update_serial: 25
   ServicesDefault:
     - OS::TripleO::Services::Aide

roles/ComputeSriovRT.yaml

@@ -16,6 +16,7 @@
   RoleParametersDefault:
     TunedProfileName: "realtime-virtual-host"
     NovaLibvirtMemStatsPeriodSeconds: 0
+    NovaComputeDisableIrqBalance: True
   update_serial: 25
   ServicesDefault:
     - OS::TripleO::Services::Aide