From d2b607c976b4a8cf1c9926c17f750e86a0edd9d9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Harald=20Jens=C3=A5s?= Date: Thu, 19 Sep 2019 20:22:38 +0200 Subject: [PATCH] Use _uri which is wrapped if IPv6 for ironic tftp Use $NETWORK_uri for ironic::pxe::tftp_bind_host so that the wrapped ip address is picked up from hieradata when IPv6 is used. Closes-Bug: #1844713 Change-Id: I874d5eb401113fb9a1664be0b3cd29e76756d970 --- deployment/ironic/ironic-conductor-container-puppet.yaml | 2 +- .../notes/fix-ironic-pxe-tftp-ipv6-a315184667e262b3.yaml | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) create mode 100644 releasenotes/notes/fix-ironic-pxe-tftp-ipv6-a315184667e262b3.yaml diff --git a/deployment/ironic/ironic-conductor-container-puppet.yaml b/deployment/ironic/ironic-conductor-container-puppet.yaml index 26f185e781..837e639d65 100644 --- a/deployment/ironic/ironic-conductor-container-puppet.yaml +++ b/deployment/ironic/ironic-conductor-container-puppet.yaml @@ -331,7 +331,7 @@ outputs: ironic::pxe::tftp_bind_host: str_replace: template: - "%{hiera('$NETWORK')}" + "%{hiera('$NETWORK_uri')}" params: $NETWORK: {get_param: [ServiceNetMap, IronicNetwork]} # NOTE(dtantsur): UEFI only works with iPXE currently for us diff --git a/releasenotes/notes/fix-ironic-pxe-tftp-ipv6-a315184667e262b3.yaml b/releasenotes/notes/fix-ironic-pxe-tftp-ipv6-a315184667e262b3.yaml new file mode 100644 index 0000000000..6261749e5d --- /dev/null +++ b/releasenotes/notes/fix-ironic-pxe-tftp-ipv6-a315184667e262b3.yaml @@ -0,0 +1,8 @@ +--- +fixes: + - | + When using IPv6 provisioning network the tftp server used by the + Baremetal service did not start. The address passed as bind host + to the tftp server is now wrapped in `[]` to fix the issue. Bug: + `1844713 `_. +