From f606968dda39a3698ec76e80b005316d3943532f Mon Sep 17 00:00:00 2001
From: ramishra <ramishra@redhat.com>
Date: Fri, 14 May 2021 13:35:11 +0530
Subject: [PATCH] Simplify pacemaker service templates

Change-Id: Ic6bae9aa0ce400d2e3de714b40490ad6e1906ba3
---
 .../clustercheck-container-puppet.yaml        |  4 +-
 .../pacemaker/ovn-dbs-baremetal-puppet.yaml   |  1 -
 .../pacemaker/pacemaker-baremetal-puppet.yaml | 74 +++++++++----------
 3 files changed, 37 insertions(+), 42 deletions(-)

diff --git a/deployment/pacemaker/clustercheck-container-puppet.yaml b/deployment/pacemaker/clustercheck-container-puppet.yaml
index a10f4984f1..5899c3a9f9 100644
--- a/deployment/pacemaker/clustercheck-container-puppet.yaml
+++ b/deployment/pacemaker/clustercheck-container-puppet.yaml
@@ -37,7 +37,6 @@ parameters:
     type: json
 
 resources:
-
   ContainersCommon:
     type: ../containers-common.yaml
 
@@ -90,8 +89,7 @@ outputs:
             volumes:
               list_concat:
                 - {get_attr: [ContainersCommon, volumes]}
-                -
-                  - /var/lib/kolla/config_files/clustercheck.json:/var/lib/kolla/config_files/config.json
+                - - /var/lib/kolla/config_files/clustercheck.json:/var/lib/kolla/config_files/config.json
                   - /var/lib/config-data/puppet-generated/clustercheck:/var/lib/kolla/config_files/src:ro
                   - /var/lib/mysql:/var/lib/mysql
             environment:
diff --git a/deployment/pacemaker/ovn-dbs-baremetal-puppet.yaml b/deployment/pacemaker/ovn-dbs-baremetal-puppet.yaml
index 108a8840dc..68f3ca906a 100644
--- a/deployment/pacemaker/ovn-dbs-baremetal-puppet.yaml
+++ b/deployment/pacemaker/ovn-dbs-baremetal-puppet.yaml
@@ -37,7 +37,6 @@ parameters:
     default: 6642
 
 resources:
-
   OVNDBsBase:
     type: ../ovn-dbs.yaml
     properties:
diff --git a/deployment/pacemaker/pacemaker-baremetal-puppet.yaml b/deployment/pacemaker/pacemaker-baremetal-puppet.yaml
index 0ffb4e38b3..b812c99b91 100644
--- a/deployment/pacemaker/pacemaker-baremetal-puppet.yaml
+++ b/deployment/pacemaker/pacemaker-baremetal-puppet.yaml
@@ -129,8 +129,10 @@ parameter_groups:
   - CorosyncIPv6
 
 conditions:
-  pcmk_tls_priorities_empty: {equals: [{get_param: PacemakerTLSPriorities}, '']}
-  pcmk_bundle_op_timeout_empty: {equals: [{get_param: PacemakerBundleOperationTimeout}, '']}
+  pcmk_tls_priorities_set:
+    not: {equals: [{get_param: PacemakerTLSPriorities}, '']}
+  pcmk_bundle_op_timeout_set:
+    not: {equals: [{get_param: PacemakerBundleOperationTimeout}, '']}
   podman_enabled: {equals: [{get_param: ContainerCli}, 'podman']}
   is_ipv6:
     equals:
@@ -154,47 +156,43 @@ outputs:
            proto: 'udp'
            dport: 5405
       config_settings:
-        map_merge:
-        - pacemaker::corosync::cluster_name: 'tripleo_cluster'
-          pacemaker::corosync::manage_fw: false
-          pacemaker::resource_defaults::defaults:
-            resource-stickiness: { value: INFINITY }
-          corosync_token_timeout: 10000
-          pacemaker::corosync::settle_tries: {get_param: CorosyncSettleTries}
-          pacemaker::resource::bundle::deep_compare: true
-          pacemaker::resource::ip::deep_compare: true
-          pacemaker::resource::ocf::deep_compare: true
-          corosync_ipv6: {if: [is_ipv6, true, false]}
-          tripleo::fencing::config: {get_param: FencingConfig}
-          tripleo::fencing::deep_compare: true
-          enable_fencing: {get_param: EnableFencing}
-          hacluster_pwd: {get_param: PcsdPassword}
-          tripleo::profile::base::pacemaker::remote_authkey: {get_param: PacemakerRemoteAuthkey}
-          tripleo::profile::base::pacemaker::pcsd_bind_addr:
-            str_replace:
-              template:
-                "%{hiera('$NETWORK')}"
-              params:
-                $NETWORK: {get_param: [ServiceNetMap, PacemakerNetwork]}
-        -
+        pacemaker::corosync::cluster_name: 'tripleo_cluster'
+        pacemaker::corosync::manage_fw: false
+        pacemaker::resource_defaults::defaults:
+          resource-stickiness: { value: INFINITY }
+        corosync_token_timeout: 10000
+        pacemaker::corosync::settle_tries: {get_param: CorosyncSettleTries}
+        pacemaker::resource::bundle::deep_compare: true
+        pacemaker::resource::ip::deep_compare: true
+        pacemaker::resource::ocf::deep_compare: true
+        corosync_ipv6: {if: [is_ipv6, true, false]}
+        tripleo::fencing::config: {get_param: FencingConfig}
+        tripleo::fencing::deep_compare: true
+        enable_fencing: {get_param: EnableFencing}
+        hacluster_pwd: {get_param: PcsdPassword}
+        tripleo::profile::base::pacemaker::remote_authkey: {get_param: PacemakerRemoteAuthkey}
+        tripleo::profile::base::pacemaker::pcsd_bind_addr:
+          str_replace:
+            template:
+              "%{hiera('$NETWORK')}"
+            params:
+              $NETWORK: {get_param: [ServiceNetMap, PacemakerNetwork]}
+        tripleo::pacemaker::tls_priorities:
           if:
-          - pcmk_tls_priorities_empty
-          - {}
-          - tripleo::pacemaker::tls_priorities: {get_param: PacemakerTLSPriorities}
-        -
+            - pcmk_tls_priorities_set
+            - {get_param: PacemakerTLSPriorities}
+        tripleo::profile::base::pacemaker::resource_op_defaults:
           if:
-          -  and:
-             - pcmk_bundle_op_timeout_empty
-             - not: podman_enabled
-          - {}
-          - tripleo::profile::base::pacemaker::resource_op_defaults:
-              bundle:
+            - and:
+                - pcmk_bundle_op_timeout_set
+                - podman_enabled
+            - bundle:
                 name: timeout
                 value:
                   if:
-                  - pcmk_bundle_op_timeout_empty
-                  - '120s'
-                  - {get_param: PacemakerBundleOperationTimeout}
+                    - pcmk_bundle_op_timeout_set
+                    - {get_param: PacemakerBundleOperationTimeout}
+                    - '120s'
       service_config_settings:
         rsyslog:
           tripleo_logging_sources_pacemaker: