Remove Nova from undercloud during upgrades

Note that one-off init containers should be removed as well.

Related-bug: #1959662
Change-Id: I9380cc4c62acc6860f7a1e5869131fa3406e2d98
Signed-off-by: Bogdan Dobrelya <bdobreli@redhat.com>
(cherry picked from commit 219817528f)

deployment/undercloud/undercloud-upgrade.yaml

@@ -74,6 +74,43 @@ outputs:
             - step|int == 0
             - ansible_facts['distribution_major_version'] is version('8', '==')
             - dnf_module_list|length > 0
+        - name: Clean up Nova containers
+          when: step|int == 0
+          block:
+            - name: Stop nova containers
+              import_role:
+                name: tripleo_container_stop
+              vars:
+                tripleo_containers_to_stop: &nova_containers
+                  - nova_api
+                  - nova_api_cron
+                  - nova_conductor
+                  - nova_scheduler
+                  - placement_api
+                  - nova_compute
+
+            - name: Remove nova containers
+              import_role:
+                name: tripleo_container_rm
+              vars:
+                containers_to_rm: *nova_containers
+
+            - name: Remove one-off nova init-containers
+              import_role:
+                name: tripleo_container_rm
+              vars:
+                containers_to_rm:
+                  - nova_api_db_sync
+                  - nova_api_init_logs
+                  - nova_api_map_cell0
+                  - nova_api_ensure_default_cell
+                  - nova_statedir_owner
+                  - nova_wait_for_compute_service
+                  - nova_wait_for_api_service
+                  - nova_db_sync
+                  - placement_api_db_sync
+                  - placement_wait_for_service
+                  - placement_init_log
         - name: migrate existing introspection data
           shell: >
             {{ container_cli }} exec -u root ironic_inspector ironic-inspector-migrate-data

environments/undercloud.yaml

@@ -86,7 +86,7 @@ parameter_defaults:
   TokenExpiration: 14400
   EnablePackageInstall: true
   StackAction: CREATE
-  UndercloudNetworkConfigUpdate: True 
+  UndercloudNetworkConfigUpdate: True
   NeutronTunnelTypes: []
   NeutronBridgeMappings: ctlplane:br-ctlplane
   NeutronAgentExtensions: []