openstack/tripleo-heat-templates
Code Issues Proposed changes

Start sequence at 1 for deploy steps playbook

Browse Source 
We should start the sequence at 1 instead of 0, since all our puppet
manifests assume the first step is 1. Trying to run our puppet manifests
with a hieradata value of step=0 actually results in an error because no
classes are included.

Change-Id: I93dc8b4cefbd729ba7afa3a4d81b4ac95344cac2
Closes-Bug: #1717292
This commit is contained in:
James Slagle 2017-09-14 09:31:58 -06:00
parent 4c7ecb8e84
commit 320f80dbae
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
common/deploy-steps.j2
View File

@ -331,7 +331,7 @@ outputs:
when: role_name == '{{role.name}}'
{%- endfor %}
- include: deploy_steps_tasks.yaml
with_sequence: start=0 end={{deploy_steps_max-1}}
with_sequence: count={{deploy_steps_max-1}}
loop_control:
loop_var: step
update_steps_tasks: |
@ -344,11 +344,11 @@ outputs:
serial: 1
tasks:
- include: update_steps_tasks.yaml
with_sequence: start=0 end={{update_steps_max-1}}
with_sequence: start=1 end={{update_steps_max-1}}
loop_control:
loop_var: step
- include: deploy_steps_tasks.yaml
with_sequence: start=0 end={{deploy_steps_max-1}}
with_sequence: start=1 end={{deploy_steps_max-1}}
loop_control:
loop_var: step
upgrade_steps_tasks: |
@ -360,6 +360,6 @@ outputs:
- hosts: overcloud
tasks:
- include: upgrade_steps_tasks.yaml
with_sequence: start=0 end={{upgrade_steps_max-1}}
with_sequence: start=1 end={{upgrade_steps_max-1}}
loop_control:
loop_var: step

4
releasenotes/notes/start-sequence-1-deploy-steps-59043a5ea87a83f8.yaml Normal file
View File

@ -0,0 +1,4 @@
---
fixes:
- Start sequence at 1 for the downloaded deploy steps playbook instead of 0.
The first step should be 1 since that is what the puppet manifests expect.