Merge "Silence huge human-unreadable logs"

deployment/haproxy/haproxy-container-puppet.yaml

@@ -110,7 +110,6 @@ parameters:
     description: The directory of the CRL PEM file to be mounted.
 
 conditions:
-  puppet_debug_enabled: {get_param: ConfigDebug}
   internal_tls_enabled: {equals: [{get_param: EnableInternalTLS}, true]}
   public_tls_enabled:
     and:
@@ -318,27 +317,27 @@ outputs:
                     state: restarted
                   when: logconfig is changed
         - name: Run puppet on the host to apply IPtables rules
+          no_log: true
           when: step|int == 1
+          register: puppet_host_outputs
           shell: |
-            set +e
+            puppet apply {{ (puppet_debug|bool) | ternary('--debug --verbose', '') }} --detailed-exitcodes --summarize --color=false \
-            puppet apply {{ puppet_debug }} --detailed-exitcodes --summarize --color=false \
                 --modulepath '{{ puppet_modulepath }}' --tags '{{ puppet_tags }}' -e '{{ puppet_execute }}'
-            rc=$?
+          register: puppet_host_outputs
-            set -e
+          changed_when: puppet_host_outputs.rc == 2
-            set +ux
+          failed_when: false
-            if [ $rc -eq 2 -o $rc -eq 0 ]; then
-                exit 0
-            fi
-            exit $rc
           vars:
             puppet_execute: include tripleo::profile::base::haproxy
             puppet_tags: tripleo::firewall::rule
             puppet_modulepath: /etc/puppet/modules:/opt/stack/puppet-modules:/usr/share/openstack-puppet/modules
-            puppet_debug:
+            puppet_debug: {get_param: ConfigDebug}
-              if:
+        - name: "Debug output for task: Run puppet on the host to apply IPtables rules"
-                - puppet_debug_enabled
+          debug:
-                - '--debug --verbose'
+            var: puppet_host_outputs.stdout_lines | default([]) | union(puppet_host_outputs.stderr_lines | default([]))
-                - ''
+          when:
+            - not (ansible_check_mode | bool)
+            - puppet_host_outputs.rc is defined
+          failed_when: puppet_host_outputs.rc not in [0, 2]
       upgrade_tasks:
         - name: ensure we have haproxy log dir with the correct setype
           file:

deployment/haproxy/haproxy-pacemaker-puppet.yaml

@@ -310,17 +310,25 @@ outputs:
             - { 'path': /var/lib/haproxy, 'setype': container_file_t }
             - { 'path': /var/log/haproxy, 'setype': container_file_t }
         - name: Run puppet on the host to apply IPtables rules
+          no_log: true
           shell: |
             puppet apply {{ (puppet_debug|bool) | ternary('--debug --verbose', '') }} --detailed-exitcodes --summarize --color=false \
                 --modulepath '{{ puppet_modulepath }}' --tags '{{ puppet_tags }}' -e '{{ puppet_execute }}'
-          register: puppet_run
+          register: puppet_host_outputs
-          changed_when: puppet_run.rc == 2
+          changed_when: puppet_host_outputs.rc == 2
-          failed_when: puppet_run.rc != 2 and puppet_run.rc != 0
+          failed_when: false
           vars:
             puppet_execute: "if hiera('enable_load_balancer', true) { class {'::tripleo::haproxy': use_internal_certificates => false, manage_firewall => hiera('tripleo::firewall::manage_firewall', true), }}"
             puppet_tags: tripleo::firewall::rule
             puppet_modulepath: /etc/puppet/modules:/opt/stack/puppet-modules:/usr/share/openstack-puppet/modules
             puppet_debug: {get_param: ConfigDebug}
+        - name: "Debug output for task: Run puppet on the host to apply IPtables rules"
+          debug:
+            var: puppet_host_outputs.stdout_lines | default([]) | union(puppet_host_outputs.stderr_lines | default([]))
+          when:
+            - not (ansible_check_mode | bool)
+            - puppet_host_outputs.rc is defined
+          failed_when: puppet_host_outputs.rc not in [0, 2]
       metadata_settings:
         {get_attr: [HAProxyBase, role_data, metadata_settings]}
       deploy_steps_tasks: