From 4e078fc42de7a97d42e95301ccb0c68d5b0fb7bb Mon Sep 17 00:00:00 2001 From: Saravanan KR Date: Wed, 5 Jan 2022 11:25:18 +0530 Subject: [PATCH] Handle ping test ips when not available Deploy without gateway in the network data, the ping test fails because no valid ip address. Added default value when not present. ping_test_ips is a space separated string. Added default value as empty string. Also removed space (' ') from split as by default split will work based on space. Adding space string creates list with empty string [""]. ping_test_gateway_ips is a list of ips. Added default value as []. Change-Id: I987e093fc1ebb8dc47b39b914483936b6e7e4d6b --- common/deploy-steps.j2 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/deploy-steps.j2 b/common/deploy-steps.j2 index 4823b22177..51a712938b 100644 --- a/common/deploy-steps.j2 +++ b/common/deploy-steps.j2 @@ -677,8 +677,8 @@ outputs: tripleo_nodes_validation_validate_controllers_icmp: "{{ validate_controllers_icmp }}" tripleo_nodes_validation_validate_gateway_icmp: "{{ validate_gateways_icmp }}" tripleo_nodes_validation_validate_fqdn: "{{ validate_fqdn }}" - tripleo_nodes_validation_ping_test_ips: "{{ ping_test_ips.get(tripleo_role_name).split(' ') | list | unique }}" - tripleo_nodes_validation_ping_test_gateway_ips: "{{ ping_test_gateway_ips.get(tripleo_role_name) }}" + tripleo_nodes_validation_ping_test_ips: "{{ ping_test_ips.get(tripleo_role_name, '').split() | list | unique }}" + tripleo_nodes_validation_ping_test_gateway_ips: "{{ ping_test_gateway_ips.get(tripleo_role_name, []) }}" tags: - overcloud - pre_deploy_steps