Split ansible_limit with a colon.

Previously the --limit from tripleoclient assumed an operator would only
use a comma ','. It now converts all limit formats into a standardized format
that will always be colon ':' separated instead. This patch corrects issues
with upgrade tasks in Train and newer.

Change-Id: Icbd6b8568a697cbb0cf5740fc1a6c17b2b001c0e
Related-Change-Id: I190f6efe8d728f124c18ce80be715ae7c5c0da01
Signed-off-by: Luke Short <ekultails@gmail.com>

deployment/cinder/cinder-backup-pacemaker-puppet.yaml

@@ -358,7 +358,7 @@ outputs:
                 cacheable: no
               when:
                 - groups['cinder_backup'] | length > 1
-                - item.split('.')[0] in ansible_limit.split(',')
+                - item.split('.')[0] in ansible_limit.split(':')
               loop: "{{ cinder_backup_node_names | default([]) }}"
             - fail:
                 msg: >

deployment/cinder/cinder-volume-pacemaker-puppet.yaml

@@ -345,7 +345,7 @@ outputs:
                 cacheable: no
               when:
                 - groups['cinder_volume'] | length > 1
-                - item.split('.')[0] in ansible_limit.split(',')
+                - item.split('.')[0] in ansible_limit.split(':')
               loop: "{{ cinder_volume_node_names | default([]) }}"
             - fail:
                 msg: >

deployment/database/mysql-pacemaker-puppet.yaml

@@ -519,7 +519,7 @@ outputs:
                 cacheable: no
               when:
                 - groups['mysql'] | length > 1
-                - item.split('.')[0] in ansible_limit.split(',')
+                - item.split('.')[0] in ansible_limit.split(':')
               loop: "{{ mysql_node_names | default([]) }}"
             - fail:
                 msg: >

deployment/database/redis-pacemaker-puppet.yaml

@@ -444,7 +444,7 @@ outputs:
                 cacheable: no
               when:
                 - groups['redis'] | length > 1
-                - item.split('.')[0] in ansible_limit.split(',')
+                - item.split('.')[0] in ansible_limit.split(':')
               loop: "{{ redis_short_node_names | default([]) }}"
             - fail:
                 msg: >

deployment/haproxy/haproxy-pacemaker-puppet.yaml

@@ -540,7 +540,7 @@ outputs:
                 cacheable: no
               when:
                 - groups['haproxy'] | length > 1
-                - item.split('.')[0] in ansible_limit.split(',')
+                - item.split('.')[0] in ansible_limit.split(':')
               loop: "{{ haproxy_short_node_names | default([]) }}"
             - fail:
                 msg: >

deployment/manila/manila-share-pacemaker-puppet.yaml

@@ -324,7 +324,7 @@ outputs:
                 cacheable: no
               when:
                 - groups['manila_share'] | length > 1
-                - item.split('.')[0] in ansible_limit.split(',')
+                - item.split('.')[0] in ansible_limit.split(':')
               loop: "{{ manila_share_node_names | default([]) }}"
             - fail:
                 msg: >

deployment/ovn/ovn-dbs-pacemaker-puppet.yaml

@@ -456,7 +456,7 @@ outputs:
                 cacheable: no
               when:
                 - groups['ovn_dbs'] | length > 1
-                - item.split('.')[0] in ansible_limit.split(',')
+                - item.split('.')[0] in ansible_limit.split(':')
               loop: "{{ ovn_dbs_short_node_names | default([]) }}"
             - fail:
                 msg: >

deployment/pacemaker/pacemaker-baremetal-puppet.yaml

@@ -237,7 +237,7 @@ outputs:
                 cacheable: no
               when:
                 - groups['pacemaker'] | length > 1
-                - item.split('.')[0] in ansible_limit.split(',')
+                - item.split('.')[0] in ansible_limit.split(':')
               loop: "{{ pacemaker_short_node_names | default([]) }}"
             - fail:
                 msg: >

deployment/rabbitmq/rabbitmq-messaging-notify-pacemaker-puppet.yaml

@@ -393,7 +393,7 @@ outputs:
                 cacheable: no
               when:
                 - groups['oslo_messaging_notify'] | length > 1
-                - item.split('.')[0] in ansible_limit.split(',')
+                - item.split('.')[0] in ansible_limit.split(':')
               loop: "{{ oslo_messaging_notify_node_names | default([]) }}"
             - fail:
                 msg: >

deployment/rabbitmq/rabbitmq-messaging-pacemaker-puppet.yaml

@@ -392,7 +392,7 @@ outputs:
                 cacheable: no
               when:
                 - groups['rabbitmq'] | length > 1
-                - item.split('.')[0] in ansible_limit.split(',')
+                - item.split('.')[0] in ansible_limit.split(':')
               loop: "{{ rabbitmq_short_node_names | default([]) }}"
             - fail:
                 msg: >

deployment/rabbitmq/rabbitmq-messaging-rpc-pacemaker-puppet.yaml

@@ -399,7 +399,7 @@ outputs:
                 cacheable: no
               when:
                 - groups['oslo_messaging_rpc'] | length > 1
-                - item.split('.')[0] in ansible_limit.split(',')
+                - item.split('.')[0] in ansible_limit.split(':')
               loop: "{{ oslo_messaging_rpc_node_names | default([]) }}"
             - fail:
                 msg: >