Browse Source

Use include_role for conditional inclusion

When import_role is used with a condition, the condition is
applied to all tasks in the role. This is inefficient. If we
use include_role instead, then the role inclusion task is
skipped and none of the tasks in the role are even evaluated.

Related-bug: rhbz#1922132

Change-Id: I1b4e26fd4a46599985a989441f493a3ed39237bb
changes/91/772991/1
Jesse Pretorius (odyssey4me) 8 months ago
parent
commit
46df551a0f
  1. 2
      deployment/metrics/collectd-container-puppet.yaml

2
deployment/metrics/collectd-container-puppet.yaml

@ -787,6 +787,6 @@ outputs:
with_items:
- { 'path': /var/log/containers/collectd, 'setype': container_file_t, 'mode': '0750' }
- name: import provision_mcelog
import_role:
include_role:
name: tripleo_provision_mcelog
when: {get_param: CollectdEnableMcelog}
Loading…
Cancel
Save