openstack
/
tripleo-heat-templates
Code Issues Proposed changes

Configure valid_exit_code for startup containers 

For the containers managed during the deploy tasks; they can also fail
after being run (e.g. nova db sync); and right now we don't catch it,
and keep the deployment moving on.

We catch the errors with puppet containers but not for startup
containers.
This patch is a first step in that direction where we only accept
containers that have exited to return 0 as a valid return code.

A patch in tripleo-ansible will be made to check these containers which
must have "command" in their configs.

Change-Id: I43e42df53b10fc99ca8e0fd8d7a30768e895e91f
Related-Bug: #1878074
(cherry picked from commit de4dc46ea8)
changes/54/731054/5
Emilien Macchi 2020-05-11 14:51:26 -04:00
parent 8ad5f5697e
commit 4ab32733a1
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
common/deploy-steps-tasks.yaml
View File

@ -146,6 +146,7 @@
tripleo_container_manage_log_path: "{{ container_log_stdout_path }}"
tripleo_container_manage_config_patterns: '*.json'
tripleo_container_manage_check_puppet_config: true
tripleo_container_manage_valid_exit_code: [0]
tags:
- container_startup_configs