From 4ab32733a16e4661181abd59c7cad9f1a69288ca Mon Sep 17 00:00:00 2001 From: Emilien Macchi Date: Mon, 11 May 2020 14:51:26 -0400 Subject: [PATCH] Configure valid_exit_code for startup containers For the containers managed during the deploy tasks; they can also fail after being run (e.g. nova db sync); and right now we don't catch it, and keep the deployment moving on. We catch the errors with puppet containers but not for startup containers. This patch is a first step in that direction where we only accept containers that have exited to return 0 as a valid return code. A patch in tripleo-ansible will be made to check these containers which must have "command" in their configs. Change-Id: I43e42df53b10fc99ca8e0fd8d7a30768e895e91f Related-Bug: #1878074 (cherry picked from commit de4dc46ea801e6f868d07cd513977cd9992cbe81) --- common/deploy-steps-tasks.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/common/deploy-steps-tasks.yaml b/common/deploy-steps-tasks.yaml index eb01a35e8b..ce824facc9 100644 --- a/common/deploy-steps-tasks.yaml +++ b/common/deploy-steps-tasks.yaml @@ -146,6 +146,7 @@ tripleo_container_manage_log_path: "{{ container_log_stdout_path }}" tripleo_container_manage_config_patterns: '*.json' tripleo_container_manage_check_puppet_config: true + tripleo_container_manage_valid_exit_code: [0] tags: - container_startup_configs