openstack/tripleo-heat-templates
Code Issues Proposed changes

Handle ping test ips when not available

Browse Source 
Deploy without gateway in the network data, the ping test fails
because no valid ip address. Added default value when not present.

ping_test_ips is a space separated string. Added default value as
empty string. Also removed space (' ') from split as by default
split will work based on space. Adding space string creates list
with empty string [""].

ping_test_gateway_ips is a list of ips. Added default value as [].

Change-Id: I987e093fc1ebb8dc47b39b914483936b6e7e4d6b
This commit is contained in:
Saravanan KR 2022-01-05 11:25:18 +05:30
parent 4999fcae92
commit 4e078fc42d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
common/deploy-steps.j2
View File

@ -677,8 +677,8 @@ outputs:
tripleo_nodes_validation_validate_controllers_icmp: "{{ validate_controllers_icmp }}"
tripleo_nodes_validation_validate_gateway_icmp: "{{ validate_gateways_icmp }}"
tripleo_nodes_validation_validate_fqdn: "{{ validate_fqdn }}"
tripleo_nodes_validation_ping_test_ips: "{{ ping_test_ips.get(tripleo_role_name).split(' ') | list | unique }}"
tripleo_nodes_validation_ping_test_gateway_ips: "{{ ping_test_gateway_ips.get(tripleo_role_name) }}"
tripleo_nodes_validation_ping_test_ips: "{{ ping_test_ips.get(tripleo_role_name, '').split() | list | unique }}"
tripleo_nodes_validation_ping_test_gateway_ips: "{{ ping_test_gateway_ips.get(tripleo_role_name, []) }}"
tags:
- overcloud
- pre_deploy_steps