Enable deep_compare of pcmk resources by default

By settings these hiera keys we will actually do a deep comparison
of all pacemaker resources and update them accordingly.

This means that rerunning a deploy against an existing overcloud
will actually detect if a pacemaker resource needs updating and
will update the definition and restart of said resource. The code
will wait for the resource to be up (aka the cluster to settle
after an update).

Depends-On: I62d5662327333e17e1c32a029695b3d3a904ca10
Change-Id: I0b9ed429e6b1bd4a62b4462bf6312782f29b7d6b

puppet/services/pacemaker.yaml

@@ -115,6 +115,9 @@ outputs:
           resource-stickiness: { value: INFINITY }
         corosync_token_timeout: 10000
         pacemaker::corosync::settle_tries: {get_param: CorosyncSettleTries}
+        pacemaker::resource::bundle::deep_compare: true
+        pacemaker::resource::ip::deep_compare: true
+        pacemaker::resource::ocf::deep_compare: true
         tripleo.pacemaker.firewall_rules:
           '130 pacemaker tcp':
             proto: 'tcp'

releasenotes/notes/update-pcmk-resource-by-default-ed54100721f55a30.yaml

@@ -0,0 +1,8 @@
+---
+fixes:
+  - |
+    Historically if a puppet definition for a pacemaker resource did change
+    puppet would not update it. We now enable the updating of pacemaker resources
+    by default. The main use case being restarting a bundle when a bind mount gets
+    added. Puppet will wait for the resource to completely restart before
+    proceeding with the deploy.