Undercloud upgrades will use upgrade_tasks

Instead of using host_prep_tasks (which are part of deployment tasks),
we'll use the upgrade tasks that are now well known and tested in
previous releases, when the we containerized the overcloud.

Depends-On: Id25e6280b4b4f060d5e3f78a50ff83aaca9e6b1a
Change-Id: Ic199c7d431e155e2d37996acd0d7b924d14af2b7

docker/services/messaging/notify-rabbitmq.yaml

@@ -48,10 +48,6 @@ parameters:
     type: string
     description: Specifies the default CA cert to use if TLS is used for
                  services in the internal network.
-  UndercloudUpgrade:
-    type: boolean
-    description: Flag to indicate undercloud upgrade process is being run.
-    default: false
 
 conditions:
 
@@ -229,12 +225,6 @@ outputs:
               Log files from rabbitmq containers can be found under
               /var/log/containers/rabbitmq.
           ignore_errors: true
-        - name: Stop and disable the rabbitmq-server service
-          service:
-            name: rabbitmq-server
-            state: stopped
-            enabled: no
-          when: {get_param: UndercloudUpgrade}
       upgrade_tasks:
         - name: Check if rabbitmq server is deployed
           command: systemctl is-enabled --quiet rabbitmq-server

docker/services/messaging/rpc-rabbitmq.yaml

@@ -48,10 +48,6 @@ parameters:
     type: string
     description: Specifies the default CA cert to use if TLS is used for
                  services in the internal network.
-  UndercloudUpgrade:
-    type: boolean
-    description: Flag to indicate undercloud upgrade process is being run.
-    default: false
 
 conditions:
 
@@ -229,12 +225,6 @@ outputs:
               Log files from rabbitmq containers can be found under
               /var/log/containers/rabbitmq.
           ignore_errors: true
-        - name: Stop and disable the rabbitmq-server service
-          service:
-            name: rabbitmq-server
-            state: stopped
-            enabled: no
-          when: {get_param: UndercloudUpgrade}
       upgrade_tasks:
         - name: Check if rabbitmq server is deployed
           command: systemctl is-enabled --quiet rabbitmq-server