Stop services for unupgraded controllers

Before we start services on upgraded bootstrap
controller (usually controller-0), we need to
stop services on unupgraded controllers
(usually controller-1 and controller-2).

Also we need to move the mysql data transfer
to the step 2 as we need to first stop the
services.

Depends-On: I4fcc0858cac8f59d797d62f6de18c02e4b1819dc
Change-Id: Ib4af5b4a92b3b516b8e2fc1ae12c8d5abe40327f

deployment/aodh/aodh-api-container-puppet.yaml

@@ -241,6 +241,21 @@ outputs:
             containers_to_rm:
               - aodh_api
             tripleo_container_cli: "docker"
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop aodh api container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - aodh_api
+                tripleo_delegate_to: "{{ groups['aodh_api'] | default([]) }}"
       fast_forward_upgrade_tasks:
         - when:
             - step|int == 0

deployment/aodh/aodh-evaluator-container-puppet.yaml

@@ -131,6 +131,21 @@ outputs:
             containers_to_rm:
               - aodh_evaluator
             tripleo_container_cli: "docker"
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop aodh evaluator container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - aodh_evaluator
+                tripleo_delegate_to: "{{ groups['aodh_evaluator'] | default([]) }}"
       fast_forward_upgrade_tasks:
         - when:
             - step|int == 0

deployment/aodh/aodh-listener-container-puppet.yaml

@@ -131,6 +131,21 @@ outputs:
             containers_to_rm:
               - aodh_listener
             tripleo_container_cli: "docker"
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop aodh listener container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - aodh_listener
+                tripleo_delegate_to: "{{ groups['aodh_listener'] | default([]) }}"
       fast_forward_upgrade_tasks:
         - when:
             - step|int == 0

deployment/aodh/aodh-notifier-container-puppet.yaml

@@ -131,6 +131,21 @@ outputs:
             containers_to_rm:
               - aodh_notifier
             tripleo_container_cli: "docker"
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop aodh notifier container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - aodh_notifier
+                tripleo_delegate_to: "{{ groups['aodh_notifier'] | default([]) }}"
       fast_forward_upgrade_tasks:
         - when:
             - step|int == 0

deployment/ceilometer/ceilometer-agent-central-container-puppet.yaml

@@ -169,6 +169,21 @@ outputs:
             containers_to_rm:
               - ceilometer_agent_central
             tripleo_container_cli: "docker"
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop ceilometer agent central container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - ceilometer_agent_central
+                tripleo_delegate_to: "{{ groups['ceilometer_agent_central'] | default([]) }}"
       fast_forward_upgrade_tasks:
         - when:
             - step|int == 0

deployment/ceilometer/ceilometer-agent-notification-container-puppet.yaml

@@ -167,6 +167,21 @@ outputs:
             containers_to_rm:
               - ceilometer_agent_notification
             tripleo_container_cli: "docker"
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop ceilometer agent notification container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - ceilometer_agent_notification
+                tripleo_delegate_to: "{{ groups['ceilometer_agent_notification'] | default([]) }}"
       fast_forward_upgrade_tasks:
         - when:
             - step|int == 0

deployment/cinder/cinder-api-container-puppet.yaml

@@ -382,6 +382,20 @@ outputs:
               tags:
                 - online_upgrade
                 - online_upgrade_cinder
+        - when: step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop cinder api container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - cinder_api
+                  - cinder_api_cron
+                tripleo_delegate_to: "{{ groups['cinder_api'] | default([]) }}"
       post_upgrade_tasks:
         - when: step|int == 1
           import_role:

deployment/cinder/cinder-scheduler-container-puppet.yaml

@@ -159,6 +159,21 @@ outputs:
             containers_to_rm:
               - cinder_scheduler
             tripleo_container_cli: "docker"
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop cinder scheduler container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - cinder_scheduler
+                tripleo_delegate_to: "{{ groups['cinder_scheduler'] | default([]) }}"
       fast_forward_upgrade_tasks:
         - when:
             - step|int == 0

deployment/database/mysql-pacemaker-puppet.yaml

@@ -606,16 +606,12 @@ outputs:
         - vars:
             mysql_upgrade_transfer: {get_param: MysqlUpgradeTransfer}
           when:
-            - step|int == 1
+            - step|int == 2
             - mysql_upgrade_transfer
           tags:
             - never
             - system_upgrade_transfer_data
           block:
-            - name: Disable mysql
-              become: true
-              command: /usr/sbin/pcs resource disable galera-bundle --wait
-              delegate_to: "{{hostvars[groups['overcloud'][0]]['mysql_short_node_names'][1]}}"
             - name: Transfer mysql data
               include_role:
                 name: tripleo-transfer

deployment/database/redis-container-puppet.yaml

@@ -246,6 +246,27 @@ outputs:
           package:
             name: redis
             state: absent
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop redis container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  with_items:
+                    list_concat:
+                      - - redis
+                      - - if:
+                            - internal_tls_enabled
+                            - - redis_tls_proxy
+                            - null
+                tripleo_delegate_to: "{{ groups['redis'] | default([]) }}"
       post_upgrade_tasks:
         - when: step|int == 1
           import_role:

deployment/deprecated/panko/panko-api-container-puppet.yaml

@@ -339,3 +339,19 @@ outputs:
               - panko_api
               - panko_api_cron
             tripleo_container_cli: "docker"
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop panko containers
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - panko_api
+                  - panko_api_cron
+                tripleo_delegate_to: "{{ groups['panko_api'] | default([]) }}"

deployment/glance/glance-api-container-puppet.yaml

@@ -612,6 +612,21 @@ outputs:
                         - - glance_api_tls_proxy
                         - null
             tripleo_container_cli: "docker"
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop glance api container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - glance_api
+                tripleo_delegate_to: "{{ groups['glance_api'] | default([]) }}"
       fast_forward_upgrade_tasks:
         - when:
             - step|int == 0

deployment/gnocchi/gnocchi-api-container-puppet.yaml

@@ -382,6 +382,21 @@ outputs:
             containers_to_rm:
               - gnocchi_api
             tripleo_container_cli: "docker"
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop gnocchi container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - gnocchi_api
+                tripleo_delegate_to: "{{ groups['gnocchi_api'] | default([]) }}"
       fast_forward_upgrade_tasks:
         - when:
             - step|int == 0

deployment/gnocchi/gnocchi-metricd-container-puppet.yaml

@@ -186,6 +186,21 @@ outputs:
             containers_to_rm:
               - gnocchi_metricd
             tripleo_container_cli: "docker"
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop gnocchi metricd container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - gnocchi_metricd
+                tripleo_delegate_to: "{{ groups['gnocchi_metricd'] | default([]) }}"
       fast_forward_upgrade_tasks:
         - when:
             - step|int == 0

deployment/gnocchi/gnocchi-statsd-container-puppet.yaml

@@ -180,6 +180,21 @@ outputs:
             containers_to_rm:
               - gnocchi_statsd
             tripleo_container_cli: "docker"
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop gnocchi statsd container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - gnocchi_statsd
+                tripleo_delegate_to: "{{ groups['gnocchi_statsd'] | default([]) }}"
       fast_forward_upgrade_tasks:
         - name: FFU check if openstack-gnocchi-statsd is deployed
           command: systemctl is-enabled --quiet openstack-gnocchi-statsd

deployment/haproxy/haproxy-container-puppet.yaml

@@ -323,6 +323,21 @@ outputs:
             containers_to_rm:
               - haproxy
             tripleo_container_cli: "docker"
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop haproxy container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - haproxy
+                tripleo_delegate_to: "{{ groups['haproxy'] | default([]) }}"
       host_prep_tasks:
         - {get_attr: [HAProxyPublicTLS, role_data, host_prep_tasks]}
         - name: Check if rsyslog exists

deployment/heat/heat-api-cfn-container-puppet.yaml

@@ -224,6 +224,21 @@ outputs:
             containers_to_rm:
               - heat_api_cfn
             tripleo_container_cli: "docker"
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop heat cfn container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - heat_api_cfn
+                tripleo_delegate_to: "{{ groups['heat_api_cfn'] | default([]) }}"
       fast_forward_upgrade_tasks:
         - when:
             - step|int == 0

deployment/heat/heat-api-container-puppet.yaml

@@ -273,6 +273,22 @@ outputs:
               - heat_api
               - heat_api_cron
             tripleo_container_cli: "docker"
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop heat api container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - heat_api
+                  - heat_api_cron
+                tripleo_delegate_to: "{{ groups['heat_api'] | default([]) }}"
       fast_forward_upgrade_tasks:
         - when:
             - step|int == 0

deployment/heat/heat-engine-container-puppet.yaml

@@ -285,6 +285,21 @@ outputs:
             containers_to_rm:
               - heat_engine
             tripleo_container_cli: "docker"
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop heat engine container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - heat_engine
+                tripleo_delegate_to: "{{ groups['heat_engine'] | default([]) }}"
       fast_forward_upgrade_tasks:
         - when:
             - step|int == 0

deployment/horizon/horizon-container-puppet.yaml

@@ -337,3 +337,18 @@ outputs:
             containers_to_rm:
               - horizon
             tripleo_container_cli: "docker"
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop horizon container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - horizon
+                tripleo_delegate_to: "{{ groups['horizon'] | default([]) }}"

deployment/keystone/keystone-container-puppet.yaml

@@ -797,6 +797,22 @@ outputs:
               - keystone
               - keystone_cron
             tripleo_container_cli: "docker"
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop keystone container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - keystone
+                  - keystone_cron
+                tripleo_delegate_to: "{{ groups['keystone'] | default([]) }}"
       fast_forward_upgrade_tasks:
         - when:
             - step|int == 0

deployment/logrotate/logrotate-crond-container-puppet.yaml

@@ -136,3 +136,18 @@ outputs:
             containers_to_rm:
               - logrotate_crond
             tripleo_container_cli: "docker"
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop logrotate container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - logrotate_crond
+                tripleo_delegate_to: "{{ groups['logrotate_crond'] | default([]) }}"

deployment/memcached/memcached-container-puppet.yaml

@@ -193,6 +193,21 @@ outputs:
             containers_to_rm:
               - memcached
             tripleo_container_cli: "docker"
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop memcached container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - memcached
+                tripleo_delegate_to: "{{ groups['memcached'] | default([]) }}"
       fast_forward_upgrade_tasks:
         - when:
             - step|int == 0

deployment/neutron/neutron-api-container-puppet.yaml

@@ -468,6 +468,21 @@ outputs:
                         - - neutron_server_tls_proxy
                         - null
             tripleo_container_cli: "docker"
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop neutron api container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - neutron_api
+                tripleo_delegate_to: "{{ groups['neutron_api'] | default([]) }}"
       fast_forward_upgrade_tasks:
         - when:
             - step|int == 0

deployment/nova/nova-api-container-puppet.yaml

@@ -457,6 +457,21 @@ outputs:
               tags:
                 - online_upgrade
                 - online_upgrade_nova
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop nova api container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - nova_api
+                  - nova_api_cron
+                tripleo_delegate_to: "{{ groups['nova_api'] | default([]) }}"
       post_upgrade_tasks:
         - when: step|int == 1
           import_role:

deployment/nova/nova-conductor-container-puppet.yaml

@@ -207,6 +207,21 @@ outputs:
             containers_to_rm:
               - nova_conductor
             tripleo_container_cli: "docker"
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop nova conductor container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - nova_conductor
+                tripleo_delegate_to: "{{ groups['nova_conductor'] | default([]) }}"
       fast_forward_upgrade_tasks:
         - when:
             - step|int == 0

deployment/nova/nova-metadata-container-puppet.yaml

@@ -235,6 +235,21 @@ outputs:
             environment:
               - KOLLA_CONFIG_STRATEGY=COPY_ALWAYS
       host_prep_tasks: {get_attr: [NovaMetadataLogging, host_prep_tasks]}
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop nova metadata container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - nova_metadata
+                tripleo_delegate_to: "{{ groups['nova_metadata'] | default([]) }}"
       post_upgrade_tasks:
         - when: step|int == 1
           import_role:

deployment/nova/nova-scheduler-container-puppet.yaml

@@ -222,3 +222,18 @@ outputs:
             containers_to_rm:
               - nova_scheduler
             tripleo_container_cli: "docker"
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop nova scheduler container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - nova_scheduler
+                tripleo_delegate_to: "{{ groups['nova_scheduler'] | default([]) }}"

deployment/nova/nova-vnc-proxy-container-puppet.yaml

@@ -311,3 +311,18 @@ outputs:
             containers_to_rm:
               - nova_vnc_proxy
             tripleo_container_cli: "docker"
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop nova vnc proxy container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - nova_vnc_proxy
+                tripleo_delegate_to: "{{ groups['nova_vnc_proxy'] | default([]) }}"

deployment/pacemaker/clustercheck-container-puppet.yaml

@@ -105,3 +105,18 @@ outputs:
             containers_to_rm:
               - clustercheck
             tripleo_container_cli: "docker"
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_transfer_data
+            - system_upgrade_stop_services
+          block:
+            - name: Stop clustercheck container
+              import_role:
+                name: tripleo-container-stop
+              vars:
+                tripleo_containers_to_stop:
+                  - clustercheck
+                tripleo_delegate_to: "{{ groups['clustercheck'] | default([]) }}"

deployment/pacemaker/pacemaker-baremetal-puppet.yaml

@@ -272,6 +272,24 @@ outputs:
             - name: Start pacemaker cluster
               pacemaker_cluster: state=online
               when: not upgrade_leapp_enabled
+      external_upgrade_tasks:
+        - when:
+            - step|int == 1
+          tags:
+            - never
+            - system_upgrade_stop_services
+            - system_upgrade_transfer_data
+          block:
+            - name: Stop cluster
+              become: true
+              shell: |
+                set -eu
+                FILE=/usr/sbin/pcs
+                if test -f "$FILE"; then
+                  /usr/sbin/pcs cluster stop --force
+                fi
+              delegate_to: "{{ item }}"
+              with_items: "{{ groups['pacemaker'] | default([]) }}"
       update_tasks:
         - name: Check pacemaker cluster running before the minor update
           when: step|int == 0  # TODO(marios) disabling validations?