openstack
/
tripleo-heat-templates
Code Issues Proposed changes

Use --disable= in subscription-manager to avoid shell expansion. 

In extraconfig/pre_deploy/rhel-registration/scripts/rhel-registration,
there's a line that says:

   retry subscription-manager repos --disable '*'

I believe this is broken and will result in shell expansion being made.
The proper line should be:

   retry subscription-manager repos --disable='*'

This regression came from commit 2b06ed8adc.
(Also see https://review.openstack.org/#/c/381233 )

This patch fixes the regression while preserving functionality
of the above change.

Closes-Bug: 1667316

Change-Id: I54f0db3f1f596f6356f7445cdc61737f20f14318
Signed-off-by: Vincent S. Cojot <vincent@cojot.name>
This commit is contained in:
Vincent S. Cojot 2017-02-23 09:38:24 -05:00
parent 1e1a4d415e
commit 87569bd571
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
extraconfig/pre_deploy/rhel-registration/scripts/rhel-registration
View File

@ -133,7 +133,7 @@ case "${REG_METHOD:-}" in
if [ -z "${REG_AUTO_ATTACH:-}" -a -z "${REG_ACTIVATION_KEY:-}" ]; then
retry subscription-manager attach $attach_opts
fi
retry subscription-manager repos --disable '*'
retry subscription-manager repos --disable='*'
retry subscription-manager $repos
;;
satellite)