From 969693e667aba8d893f10f7b03bafde3b3f66287 Mon Sep 17 00:00:00 2001
From: Alex Schultz <aschultz@redhat.com>
Date: Fri, 18 Dec 2020 07:55:43 -0700
Subject: [PATCH] Fix unreachable handling

When we clear the cached facts with unreachable nodes, we attempt to
gather facts by default. This can cause the node to be skipped for every
future playbook. This ends up bypassing all our failure percentage
logic.

Change-Id: Ie240877496b73a37f553a84af47dfebdbaf899e5
Related-Bug: 1908573
---
 common/deploy-steps-playbooks-common.yaml | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/common/deploy-steps-playbooks-common.yaml b/common/deploy-steps-playbooks-common.yaml
index 401308c53a..b09d3b9e9c 100644
--- a/common/deploy-steps-playbooks-common.yaml
+++ b/common/deploy-steps-playbooks-common.yaml
@@ -7,6 +7,8 @@
 
 - hosts: all
   name: Clear cached facts
+  # We don't want to gather facts, just clear them
+  gather_facts: false
   tasks:
     - meta: clear_facts
   tags:
@@ -14,14 +16,8 @@
 
 - hosts: "{{ deploy_source_host }}:{{ deploy_target_host }}"
   name: Gather facts
-  gather_facts: yes
-  # False because https://github.com/ansible/ansible/issues/70663
-  any_errors_fatal: false
-  # If an overcloud node is down, we will let MaxFailPercentage
-  # figuring out if the deployment can continue. For the facts gathering tasks,
-  # we will simply ignore unreachable nodes and errors, and let the
-  # Ansible reports the failure in the next plays.
-  ignore_unreachable: true
+  strategy: tripleo_free
+  gather_facts: true
   tags:
     - facts