Fix unreachable handling

When we clear the cached facts with unreachable nodes, we attempt to
gather facts by default. This can cause the node to be skipped for every
future playbook. This ends up bypassing all our failure percentage
logic.

Change-Id: Ie240877496b73a37f553a84af47dfebdbaf899e5
Related-Bug: 1908573
This commit is contained in:
Alex Schultz 2020-12-18 07:55:43 -07:00
parent 666091c949
commit 969693e667
1 changed files with 4 additions and 8 deletions

View File

@ -7,6 +7,8 @@
- hosts: all
name: Clear cached facts
# We don't want to gather facts, just clear them
gather_facts: false
tasks:
- meta: clear_facts
tags:
@ -14,14 +16,8 @@
- hosts: "{{ deploy_source_host }}:{{ deploy_target_host }}"
name: Gather facts
gather_facts: yes
# False because https://github.com/ansible/ansible/issues/70663
any_errors_fatal: false
# If an overcloud node is down, we will let MaxFailPercentage
# figuring out if the deployment can continue. For the facts gathering tasks,
# we will simply ignore unreachable nodes and errors, and let the
# Ansible reports the failure in the next plays.
ignore_unreachable: true
strategy: tripleo_free
gather_facts: true
tags:
- facts