docker: don't override horizon::vhost_extra_params

horizon::vhost_extra_params is already configured in
puppet/services/horizon.yaml, and users can change the value with
HorizonVhostExtraParams parameter.

Docker deployments didn't have HorizonVhostExtraParams taken in account
since we were overriding with Hiera. This patch fix it.

Closes-Bug: #1749627
Change-Id: I77f1312112c7f613d795242060709082ef72f150

docker/services/horizon.yaml

@@ -67,11 +67,6 @@ outputs:
       config_settings:
         map_merge:
           - get_attr: [HorizonBase, role_data, config_settings]
-          - horizon::vhost_extra_params:
-              add_listen: true
-              priority: 10
-              access_log_format: '%a %l %u %t \"%r\" %>s %b \"%%{}{Referer}i\" \"%%{}{User-Agent}i\"'
-              options: ['FollowSymLinks','MultiViews']
           - horizon::secure_cookies: false
       logging_source: {get_attr: [HorizonBase, role_data, logging_source]}
       logging_groups: {get_attr: [HorizonBase, role_data, logging_groups]}

puppet/services/horizon.yaml

@@ -79,6 +79,7 @@ parameters:
                  services in the internal network.
   HorizonVhostExtraParams:
     default:
+      add_listen: true
       priority: 10
       access_log_format: '%a %l %u %t \"%r\" %>s %b \"%%{}{Referer}i\" \"%%{}{User-Agent}i\"'
       options: ['FollowSymLinks','MultiViews']