openstack
/
tripleo-heat-templates
Code Issues Proposed changes

Deprecate Role and ImageBuilder metadata handling 

Our templates and elements no longer depend on `OpenStack::Role` or
`OpenStack::ImageBuilder::Elements` metadata. Using either now prints out a
deprecation warning.

Change-Id: I91e79b00bacca8caf13d4b6fa83d90e9c20b241c
This commit is contained in:
Tomas Sedovic 2014-06-25 15:03:16 +02:00
parent cdfe285f79
commit 9e262a51e9
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tripleo_heat_merge/merge.py
View File

@ -332,6 +332,9 @@ def merge(templates, master_role=None, slave_roles=None,
# XXX Assuming ImageId is always a Ref
ikey_val = end_template[lang.parameters][rbody[lang.properties][image_key][lang.get_param]]
del end_template[lang.parameters][rbody[lang.properties][image_key][lang.get_param]]
if 'OpenStack::Role' in rbody.get(lang.metadata, {}):
sys.stderr.write("WARNING: OpenStack::Role is deprecated"
" and will be removed in a later release\n");
role = rbody.get(lang.metadata, {}).get('OpenStack::Role', r)
role = translate_role(role, master_role, slave_roles)
if role != r:
@ -342,6 +345,10 @@ def merge(templates, master_role=None, slave_roles=None,
if m in end_template[lang.resources][role].get(lang.metadata, {}):
if m == 'OpenStack::ImageBuilder::Elements':
end_template[lang.resources][role][lang.metadata][m].extend(mbody)
sys.stderr.write(
"WARNING: OpenStack::ImageBuilder::Elements"
" is deprecated and will be removed in a"
" later release\n");
continue
if mbody != end_template[lang.resources][role][lang.metadata][m]:
errors.append('Role %s metadata key %s conflicts.' %