Allow more tasks to be run in check mode

When running Ansible in check mode (aka dry run), some tasks need some
changes, specially around variables and make sure they are actually
defined.

Change-Id: I337aa287f1c88a0e2707b441fc6b19b997d52385

common/deploy-steps-tasks.yaml

@@ -43,6 +43,9 @@
   delay: 3
   failed_when:
     - (not puppet_host_outputs.finished) or (puppet_host_outputs.rc is defined and puppet_host_outputs.rc not in [0, 2])
+  when:
+    - not ansible_check_mode|bool
+    - enable_puppet|bool
   tags:
     - host_config
 

deployment/cinder/cinder-common-container-puppet.yaml

@@ -166,6 +166,8 @@ outputs:
                   vg: "cinder-volumes"
                   pvs: "{{ _loopback_device.stdout }}"
                   state: present
+                when:
+                  - not ansible_check_mode|bool
               - name: cinder create service to run losetup for LVM on startup
                 copy:
                   dest: /etc/systemd/system/cinder-lvm-losetup.service
@@ -186,6 +188,8 @@ outputs:
 
                     [Install]
                     WantedBy=local-fs-pre.target
+                when:
+                  - not ansible_check_mode|bool
               - name: cinder enable the LVM losetup service
                 systemd:
                   name: cinder-lvm-losetup

deployment/haproxy/haproxy-pacemaker-puppet.yaml

@@ -381,6 +381,8 @@ outputs:
           - name: set is_haproxy_bootstrap_node fact
             tags: common
             set_fact: is_haproxy_bootstrap_node={{haproxy_short_bootstrap_node_name|lower == ansible_hostname|lower}}
+            when:
+              - haproxy_short_bootstrap_node_name is defined
         - name: Mount TLS cert if needed
           when:
             - step|int == 1

deployment/haproxy/haproxy-public-tls-inject.yaml

@@ -86,6 +86,8 @@ outputs:
 
             - name: set is_haproxy_bootstrap_node fact
               set_fact: is_haproxy_bootstrap_node={{haproxy_short_bootstrap_node_name | lower == ansible_hostname | lower}}
+              when:
+                - haproxy_short_bootstrap_node_name is defined
 
             - name: get haproxy status
               register: haproxy_state

deployment/neutron/neutron-dhcp-container-puppet.yaml

@@ -428,7 +428,9 @@ outputs:
           - - name: remove temp namespace
               command: ip netns delete ns_temp
               failed_when: false
-              when: ipnetns_add_result.rc == 0
+              when:
+                - ipnetns_add_result.rc is defined
+                - ipnetns_add_result.rc == 0
           - - name: create /var/lib/neutron
               file:
                 path: /var/lib/neutron

deployment/neutron/neutron-l3-container-puppet.yaml

@@ -383,7 +383,9 @@ outputs:
           - - name: remove temp namespace
               command: ip netns delete ns_temp
               failed_when: false
-              when: ipnetns_add_result.rc == 0
+              when:
+                - ipnetns_add_result.rc is defined
+                - ipnetns_add_result.rc == 0
           - - name: create /var/lib/neutron
               file:
                 path: /var/lib/neutron

deployment/ovn/ovn-metadata-container-puppet.yaml

@@ -374,7 +374,9 @@ outputs:
           - - name: remove temp namespace
               command: ip netns delete ns_temp
               failed_when: false
-              when: ipnetns_add_result.rc == 0
+              when:
+                - ipnetns_add_result.rc is defined
+                - ipnetns_add_result.rc == 0
           - - name: create /var/lib/neutron
               file:
                 path: /var/lib/neutron