From a364005e03d7b5e44740354bde21d2fc185f6fab Mon Sep 17 00:00:00 2001 From: Mathieu Bultel Date: Thu, 14 Nov 2019 15:02:37 +0100 Subject: [PATCH] Check if snmpd is enabled for upgrade_tasks This check should prevent some error when the upgrade tasks checks if the snmpd is stopped in step 1 Depends-On: https://review.opendev.org/#/c/695234/ Depends-On: https://review.opendev.org/#/c/695419/ Depends-On: https://review.opendev.org/#/c/695562/ Depends-On: https://review.opendev.org/#/c/696855/ Depends-On: https://review.opendev.org/#/c/695929/ Depends-On: https://review.opendev.org/#/c/696673/ Closes-Bug: #1853812 (cherry picked from commit 709a6b78bbe3ed181ab53b6055964c8b4332946d) Change-Id: I5cdc9ef6a20b7d18aaa802927959b81a08334753 --- deployment/snmp/snmp-baremetal-puppet.yaml | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/deployment/snmp/snmp-baremetal-puppet.yaml b/deployment/snmp/snmp-baremetal-puppet.yaml index e3802eaaba..6e8965953d 100644 --- a/deployment/snmp/snmp-baremetal-puppet.yaml +++ b/deployment/snmp/snmp-baremetal-puppet.yaml @@ -89,6 +89,17 @@ outputs: step_config: | include ::tripleo::profile::base::snmp upgrade_tasks: + - when: step|int == 0 + block: + - name: Check if snmpd is enabled + command: systemctl is-enabled --quiet snmpd + ignore_errors: True + register: snmpd_enabled_result + - name: Set fact snmpd_enabled + set_fact: + snmpd_enabled: "{{ snmpd_enabled_result.rc == 0 }}" - name: Stop snmp service - when: step|int == 1 + when: + - step|int == 1 + - snmpd_enabled|bool service: name=snmpd state=stopped