Add new role parameter NovaLibvirtMemStatsPeriodSeconds

Add role parameter NovaLibvirtMemStatsPeriodSeconds which allows to
set `libvirt/mem_stats_period_seconds` parameter value to
number of seconds to memory usage statistics period, where
zero or negative value mean to disable memory usage statistics.

Default value for the parameter is 10.
Also set the default value to 0 for Real-Time Compute roles.

Conflicts:
      roles/ComputeOvsDpdkRT.yaml
      roles/ComputeOvsDpdkSriovRT.yaml

Resolved conflict related to ordering of parameters in
RoleParametersDefault section.

Depends-On: https://review.opendev.org/#/c/671399/
Change-Id: I8e1a81bc69b4d266755ba3c2a4bf17f37d276fd7
(cherry picked from commit 66c4e23654)
(cherry picked from commit abf34de6c8)
(cherry picked from commit 85a3685bb2)

puppet/services/nova-compute.yaml

@@ -195,6 +195,14 @@ parameters:
     type: string
     default: 'regionOne'
     description: Keystone region for endpoint
+  NovaLibvirtMemStatsPeriodSeconds:
+    description: >
+      A number of seconds to memory usage statistics period, zero or negative
+      value mean to disable memory usage statistics.
+    default: 10
+    type: number
+    tags:
+      - role_specific
 
 conditions:
   enable_live_migration_tunnelled:
@@ -236,6 +244,7 @@ resources:
               nfs_share: NovaNfsShare
               nfs_options: NovaNfsOptions
               nfs_vers: NovaNfsVersion
+              nova::compute::libvirt::mem_stats_period_seconds: NovaLibvirtMemStatsPeriodSeconds
             - values: {get_param: [RoleParameters]}
           - values:
               NovaVcpuPinSet: {get_param: NovaVcpuPinSet}
@@ -248,6 +257,7 @@ resources:
               NovaNfsShare: {get_param: NovaNfsShare}
               NovaNfsOptions: {get_param: NovaNfsOptions}
               NovaNfsVersion: {get_param: NovaNfsVersion}
+              NovaLibvirtMemStatsPeriodSeconds: {get_param: NovaLibvirtMemStatsPeriodSeconds}
 
 outputs:
   role_data:

releasenotes/notes/nova_libvirt_mem_stats_period_seconds-b9b606232629cb38.yaml

@@ -0,0 +1,8 @@
+---
+features:
+  - |
+    Add parameter NovaLibvirtMemStatsPeriodSeconds, which allows to
+    set `libvirt/mem_stats_period_seconds` parameter value to number
+    of seconds to memory usage statistics period, zero or negative
+    value mean to disable memory usage statistics.
+    Default value for NovaLibvirtMemStatsPeriodSeconds is 10.

roles/ComputeOvsDpdkRT.yaml

@@ -16,6 +16,7 @@
     TunedProfileName: "realtime-virtual-host"
     NovaLibvirtRxQueueSize: 1024
     NovaLibvirtTxQueueSize: 1024
+    NovaLibvirtMemStatsPeriodSeconds: 0
   disable_upgrade_deployment: True
   update_serial: 25
   ServicesDefault:

roles/ComputeOvsDpdkSriovRT.yaml

@@ -15,6 +15,7 @@
     TunedProfileName: "realtime-virtual-host"
     NovaLibvirtRxQueueSize: 1024
     NovaLibvirtTxQueueSize: 1024
+    NovaLibvirtMemStatsPeriodSeconds: 0
   disable_upgrade_deployment: True
   update_serial: 25
   ServicesDefault:

roles/ComputeRealTime.yaml

@@ -20,6 +20,7 @@
     KernelArgs: ""      # these must be set in an environment file or similar
     IsolCpusList: ""    # according to the hardware of real-time nodes
     NovaVcpuPinSet: ""  #
+    NovaLibvirtMemStatsPeriodSeconds: 0
   update_serial: 25
   ServicesDefault:
     - OS::TripleO::Services::Aide

roles/ComputeSriovRT.yaml

@@ -14,6 +14,7 @@
   ImageDefault: overcloud-realtime-compute
   RoleParametersDefault:
     TunedProfileName: "realtime-virtual-host"
+    NovaLibvirtMemStatsPeriodSeconds: 0
   update_serial: 25
   ServicesDefault:
     - OS::TripleO::Services::Aide