check mode: paunch configs

Adds initial check mode support for the paunch container startup
configuration and kolla config files. This cleans up the formatting of
the generated files so that the diff shown duing check mode with --diff
is useful.

We can't actually run paunch during check mode as it doesn't yet have
any support for a dry run mode.

Change-Id: I9add7b9fda50847c111e91735bd55a1ddf32f696

common/deploy-steps-tasks.yaml

@@ -213,17 +213,18 @@
 
         - name: Write docker-container-startup-configs
           copy:
-            content: "{{ docker_config_with_default | to_json }}"
+            content: "{{ docker_config_with_default | to_nice_json }}"
             dest: /var/lib/docker-container-startup-configs.json
             force: yes
             mode: '0600'
           tags:
             - container_startup_configs
+          diff: no
 
         - name: Write per-step docker-container-startup-configs
           copy:
-            content: "{{ item[1] | to_json }}"
+            content: "{{ item[1] | to_nice_json }}"
-            dest: "/var/lib/tripleo-config/docker-container-startup-config-{{ item[0] }}.json"
+            dest: /var/lib/tripleo-config/docker-container-startup-config-{{ item[0] }}.json
             force: yes
             mode: '0600'
           loop: "{{ docker_config_with_default | dictsort }}"
@@ -251,7 +252,7 @@
 
         - name: Write kolla config json files
           copy:
-            content: "{{ item[1] | to_json }}"
+            content: "{{ item[1] | to_nice_json }}"
             dest: "{{ item[0] }}"
             force: yes
             mode: '0600'
@@ -450,7 +451,6 @@
         --file /var/lib/tripleo-config/hashed-docker-container-startup-config-step_{{ step }}.json
         --config-id tripleo_step{{ step }} --managed-by tripleo-{{ tripleo_role_name }}
       changed_when: false
-      check_mode: no
       register: outputs
       failed_when: false
       no_log: true